First of all excuse me if in the previous pull request I didn't follow guidelines by devel-git-commit guide :) As anticipated in the previous request I made some changes to dispatcher module for counting successful ping requests before moving a destination from inactive to active state. While doing this changes I noticed some misspelled variables (in code and docs too) and I fixed them. So I've used similar variables (with the corrected words) also for the new feature I developed. In the case we leave the old variables introducing the new one we will have in the code: "ds_probing_threshhold" vs "ds_inactive_threshold" This behaviour could be confusing while editing the configuration file and also while reading the code.
As you requested I've separated the misspelled fixes in two commits one for the code and one for the docs. To this pull request will follow the one with the changes developing the new feature. You can merge this Pull Request by running:
git pull https://github.com/alezzandro/kamailio master
Or you can view, comment on it, or merge it online at:
https://github.com/kamailio/kamailio/pull/13
-- Commit Summary --
* dispatcher: Fixing misspelled words in some code's variables * dispatcher: Fixing misspelled words in some docs
-- File Changes --
M modules/dispatcher/README (12) M modules/dispatcher/config.c (4) M modules/dispatcher/config.h (2) M modules/dispatcher/dispatch.c (5) M modules/dispatcher/dispatch.h (3) M modules/dispatcher/dispatcher.c (11) M modules/dispatcher/doc/dispatcher_admin.xml (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/13.patch https://github.com/kamailio/kamailio/pull/13.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/13
I made some comments inline to get the patches merged clean. There is a mismatch in the code and documentation about the default value of the new parameter. Then, trying to keep the lines within 80chars size is rather important. Few other bits and pieces I commented about.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/13#issuecomment-68607421
@miconda I've just followed all your suggestions and pushed all the commits, please let me know if I need to change something more. Thanks.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/13#issuecomment-69356578
Merged #13.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/13#event-216691595