linuxmaniac commented on this pull request.

• if (get_str_fparam(&subst, msg, fp) != 0)

+ { + LM_ERR("error fetching subst re"); + return -1; + } + + LM_DBG("%s preparing %s\n", exports.name, subst.s); + + se=subst_parser(&subst); + if (se==0) + { + LM_ERR("%s: bad subst re %s\n", exports.name, subst.s); + return E_BAD_RE; + } + + return ops_subst(msg, (struct fis_param**)src, se);

Yes, indeed. Thanks!

Looking further at this patch, it requires to have the second parameter as a single variable to be considered with "pvar" support, because I see you search for `/` in the second parameter. It makes it support like:

``` $var(se) = "/abc/xyz/"; avp_subst("$avp(x)", "$var(se)"); ```

Right now it support PV in the replacement part of the subst expression, not allowing the match/regexp part.

Maybe is better to just add a new function that will always evaluate the subst parameter with variables, allowing more flexible format for subst parameter. At the end, you just need to have your added code in a dedicated function that evaluates first the parameter and then compiles the subst expression.

So we can have:

``` avp_susbtx("$avp(x)", "/$fU/$rU/g"); ``` Allowing also:

``` $var(se) = "/" + $fU + "/" + $rU + "/"; avp_substx("$avp(x)", "$var(se)"); ``` The new function can have a different name than avp_substx(), I used to exemplify here.

Added ``avp_subst_pv()`` and now this is supported: ``` $(avp(src)[*]) = "testME"; $var(x) = "/e/j/gi"; avp_subst_pv("$avp(src)", "$var(x)");

$var(z) = "j"; $var(y) = "e"; $var(x) = "/" + $var(y) + "/" + $var(z) + "/gi"; avp_subst_pv("$avp(src)", "$var(x)"); avp_subst_pv("$avp(src)", "/$var(y)/$var(z)/gi"); avp_subst_pv("$avp(src)", "/" + $var(y) + "/" + $var(z) + "/gi"); avp_subst_pv("$avp(src)", "/e/j/gi"); ```

I'm waiting for feedback. No more changes from my side.

Merged #2158 into master.