This group could be used to compile kjansson module when libevent is not available
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/990
-- Commit Summary --
* Add kjansson_basic group
-- File Changes --
M src/Makefile.groups (13)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/990.patch https://github.com/kamailio/kamailio/pull/990.diff
I wonder if makes sense to split more into groups of a single module, because it is possible to install a single module at once, which I guess it is what you are looking for.
Overall, I am not against this approach, but it may be better to understand the needs you have for packaging and other solutions may be already in place.
For example, at some point the deb packaging had the option to list the modules to be packaged separately:
* https://github.com/kamailio/kamailio/blob/master/pkg/ser/deb/debian/rules#L8... * https://github.com/kamailio/kamailio/blob/master/pkg/ser/deb/debian/rules#L1...
I feel like if we end up having a group for each module, then the grouping makes no more sense.
Maybe other can comment as well.
There is also #969 trying to redefine the packages to have less of them based on common interest.
You're completely right, having that much groups is not the best approach.
However, group_include and include_modules options can not be mixed. So I have to stick with one of these variables. I could use include_modules instead of group_include but then I would have to recopy most of what has been done in Makefile.groups that is to say trying to guess what modules should be build depending on what packages are installed on his (embedded) system.
A better approach would be to add a configure script (or Makefile variables) that would allow the user to enable/disable modules based on third-party dependencies. For example, we could add --enable-libevent, --enable-curl, --enable-ssl and so on. In case the user did not specify an enable/disable for a specific option, kamailio could use pkgconfig to try to check if the external dependency is installed on the system. Most of the open source components have this approach but it would be a bigger addition to kamailio.
For information, except kjanssson_basic, my last need would be to split kldap group as db2_ldap module depends on ldap and sasl.
Merging and we will try to find a proper solution in the future.
Merged #990.
-
Daniel-Constantin Mierla -
Fabrice Fontaine