On 02/12/14 23:24, Juha Heinanen wrote:
while working on pua_rpc module, i think i found a bug
in
pua/send_publish function. it defines
int ret = -1;
if etag check fails or publish has no body, it does this:
ret = 418;
goto error;
or
ret = ERR_PUBLISH_NO_BODY;
goto error;
at error, however, the above assignments are reverted:
error:
ret = -1;
my suggestion is to remove the above assignment. ok?
Ok if ret is set properly (to
indicate it is an error) before any goto
error.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda -
http://www.linkedin.com/in/miconda