1 Dec
2018
1 Dec
'18
7:52 p.m.
kamctl's dbtextdb.py fails to build in a Python3-only environment. Update dbtextdb to
Python3.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747
24 Dec
24 Dec
12:49 p.m.
Can you provide more details? What are the errors, what is printed, etc ...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-449711175
26 Jan
26 Jan
7:31 p.m.
@amessina - any update on this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-457844743
27 Jan
27 Jan
12:03 a.m.
@henningw unfortunately no, I have not had time to move this forward. The errors are
those typical to others found when a library was written for Python2 and hasn't been
ported to Python3--things like`print variable` changed to `print(var)`, etc. Feel free to
close out and I can reopen in the future when I have time.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-457865795
7 Oct
7 Oct
9:27 p.m.
Patch for it was merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-539143433
9:27 p.m.
Closed #1747.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#event-2692856445
4 May
4 May
1:31 p.m.
It seems that
https://github.com/kamailio/kamailio/commit/bc8bdcaa726f375f6deea8228a1ab0c…
commit broke something:
the previous version was passing:
```
$ git checkout 9df9c6e10ffe0851b7f4f2f00697c5644aaf9faa
utils/kamctl/dbtextdb $ python2 dbtextdb_test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.006s
OK
```
Now it fails for python2 and python3 (same errors):
```
python2 dbtextdb_test.py
EEE
======================================================================
ERROR: testExecute (__main__.DBTextTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "dbtextdb_test.py", line 404, in testExecute
result = db_conn.Execute(query, writethru)
File "/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py",
line 403, in Execute
self.ParseQuery(query)
File "/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py",
line 453, in ParseQuery
self._ParseCommand()
File "/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py",
line 469, in _ParseCommand
raise ParseError('Unsupported command: ' + self.command)
ParseError: Unsupported command: '
======================================================================
ERROR: testOpenTable (__main__.DBTextTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "dbtextdb_test.py", line 342, in testOpenTable
db_conn.ParseQuery(query)
File "/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py",
line 453, in ParseQuery
self._ParseCommand()
File "/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py",
line 469, in _ParseCommand
raise ParseError('Unsupported command: ' + self.command)
ParseError: Unsupported command: t
======================================================================
ERROR: testParseQuery (__main__.DBTextTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "dbtextdb_test.py", line 27, in testParseQuery
db_conn.ParseQuery(query_normal)
File "/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py",
line 453, in ParseQuery
self._ParseCommand()
File "/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py",
line 469, in _ParseCommand
raise ParseError('Unsupported command: ' + self.command)
ParseError: Unsupported command: r
----------------------------------------------------------------------
Ran 3 tests in 0.000s
FAILED (errors=3)
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-623385834
1:31 p.m.
Reopened #1747.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#event-3299247542
3:52 p.m.
with https://github.com/kamailio/kamailio/commit/b722a48144ac9e029bdbc2968dedbe5…
:
```
python2 dbtextdb_test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.006s
OK
```
But for python3:
```
python3 dbtextdb_test.py
/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py:1074:
ResourceWarning: unclosed file <_io.TextIOWrapper name='./tests/subscriber'
mode='r' encoding='UTF-8'>
self.fd = open(os.path.join(self.location, self.table), 'r')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py:1074:
ResourceWarning: unclosed file <_io.TextIOWrapper name='./tests/test'
mode='r' encoding='UTF-8'>
self.fd = open(os.path.join(self.location, self.table), 'r')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/home/vseva/data/projects/kamailio/utils/kamctl/dbtextdb/dbtextdb.py:1074:
ResourceWarning: unclosed file <_io.TextIOWrapper name='./tests/unsorted_table'
mode='r' encoding='UTF-8'>
self.fd = open(os.path.join(self.location, self.table), 'r')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/usr/lib/python3.7/unittest/case.py:615: ResourceWarning: unclosed file
<_io.TextIOWrapper name='./tests/test' mode='r'
encoding='UTF-8'>
testMethod()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
.dbtextdb_test.py:353: ResourceWarning: unclosed file <_io.TextIOWrapper
name='./tests/test' mode='r' encoding='UTF-8'>
db_conn = DBText('./tests')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
dbtextdb_test.py:363: ResourceWarning: unclosed file <_io.TextIOWrapper
name='./tests/test' mode='r' encoding='UTF-8'>
db_conn = DBText('./tests')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
dbtextdb_test.py:375: ResourceWarning: unclosed file <_io.TextIOWrapper
name='./tests/bad_table_wrong_type' mode='r' encoding='UTF-8'>
db_conn = DBText('./tests')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
dbtextdb_test.py:381: ResourceWarning: unclosed file <_io.TextIOWrapper
name='./tests/bad_table_short_row' mode='r' encoding='UTF-8'>
db_conn = DBText('./tests')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
dbtextdb_test.py:387: ResourceWarning: unclosed file <_io.TextIOWrapper
name='./tests/bad_table_long_row' mode='r' encoding='UTF-8'>
db_conn = DBText('./tests')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
dbtextdb_test.py:393: ResourceWarning: unclosed file <_io.TextIOWrapper
name='./tests/bad_table_null' mode='r' encoding='UTF-8'>
db_conn = DBText('./tests')
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/usr/lib/python3.7/unittest/case.py:615: ResourceWarning: unclosed file
<_io.TextIOWrapper name='./tests/bad_table_int' mode='r'
encoding='UTF-8'>
testMethod()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
.dbtextdb_test.py:28: DeprecationWarning: Please use assertTrue instead.
self.assert_(db_conn.command == 'SELECT')
..
----------------------------------------------------------------------
Ran 3 tests in 0.008s
OK
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-623445144
4:25 p.m.
now python2 and python3 pass the test:
```
python3 dbtextdb_test.py
...
----------------------------------------------------------------------
Ran 3 tests in 0.006s
OK
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-623462030
4:25 p.m.
Closed #1747.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#event-3299859313
4:36 p.m.
@linuxmaniac - thanks for working on this and I am not sure how you ended up with it, but
probably python2 support can be completely dropped not to make it complex to maintain. I
saw notifications on mailing list that you tested also with python2, but is no longer
maintained/installed in many distros and python3 should be available in all distro for
many years now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-623467841
4:58 p.m.
@linuxmaniac sorry for those mistakes I made in the first patch and thank you for fixing.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1747#issuecomment-623480488
1666
days inactive
2186
days old
12 comments
4 participants
participants (4)
-
Anthony Messina -
Daniel-Constantin Mierla
-
Henning Westerholt
-
Victor Seva