Module: kamailio
Branch: master
Commit: 7dc4ead50af6de77f035f32fb5eafa79a29f741c
URL:
https://github.com/kamailio/kamailio/commit/7dc4ead50af6de77f035f32fb5eafa7…
Author: Richard Fuchs <rfuchs(a)sipwise.com>
Committer: Richard Fuchs <rfuchs(a)sipwise.com>
Date: 2015-10-02T09:19:58-04:00
Merge pull request #283 from kamailio/coudot/rtpengine_read_sdp_pv
rtpengine: new read_sdp_pv parameter
---
Modified: modules/rtpengine/doc/rtpengine_admin.xml
Modified: modules/rtpengine/rtpengine.c
---
Diff:
https://github.com/kamailio/kamailio/commit/7dc4ead50af6de77f035f32fb5eafa7…
Patch:
https://github.com/kamailio/kamailio/commit/7dc4ead50af6de77f035f32fb5eafa7…
---
diff --git a/modules/rtpengine/doc/rtpengine_admin.xml
b/modules/rtpengine/doc/rtpengine_admin.xml
index bf46c76..b447387 100644
--- a/modules/rtpengine/doc/rtpengine_admin.xml
+++ b/modules/rtpengine/doc/rtpengine_admin.xml
@@ -286,6 +286,31 @@ modparam("rtpengine", "force_send_interface",
"2001:8d8:1ff:10c0:9a90:96ff:fea8:
</programlisting>
</example>
</section>
+
+ <section id="rtpengine.p.read_sdp_pv">
+ <title><varname>read_sdp_pv</varname> (string)</title>
+ <para>
+ If this parameter is set to a valid AVP or script var specifier, rtpengine
+ will take the input SDP from this pv instead of the message body.
+ </para>
+ <para>
+ There is no default value.
+ </para>
+ <example>
+ <title>Set <varname>read_sdp_pv</varname> parameter</title>
+<programlisting format="linespecific">
+...
+modparam("rtpengine", "read_sdp_pv", "$var(sdp)")
+...
+route {
+ ...
+ $var(sdp) = $rb + "a=foo:bar\r\n";
+ rtpproxy_manage();
+}
+</programlisting>
+ </example>
+ </section>
+
<section id="rtpengine.p.write_sdp_pv">
<title><varname>write_sdp_pv</varname> (string)</title>
<para>
diff --git a/modules/rtpengine/rtpengine.c b/modules/rtpengine/rtpengine.c
index 3dbd0cf..86211cc 100644
--- a/modules/rtpengine/rtpengine.c
+++ b/modules/rtpengine/rtpengine.c
@@ -255,6 +255,9 @@ static int_str setid_avp;
static str write_sdp_pvar_str = {NULL, 0};
static pv_spec_t* write_sdp_pvar = NULL;
+static str read_sdp_pvar_str = {NULL, 0};
+static pv_spec_t* read_sdp_pvar = NULL;
+
#define RTPENGINE_SESS_LIMIT_MSG "Parallel session limit reached"
#define RTPENGINE_SESS_LIMIT_MSG_LEN (sizeof(RTPENGINE_SESS_LIMIT_MSG)-1)
@@ -332,6 +335,7 @@ static param_export_t params[] = {
{"force_send_interface", PARAM_STRING, &force_send_ip_str },
{"rtp_inst_pvar", PARAM_STR, &rtp_inst_pv_param },
{"write_sdp_pv", PARAM_STR, &write_sdp_pvar_str },
+ {"read_sdp_pv", PARAM_STR, &read_sdp_pvar_str },
{0, 0, 0}
};
@@ -1403,6 +1407,16 @@ mod_init(void)
}
}
+ if (read_sdp_pvar_str.len > 0) {
+ read_sdp_pvar = pv_cache_get(&read_sdp_pvar_str);
+ if (read_sdp_pvar == NULL
+ || (read_sdp_pvar->type != PVT_AVP && read_sdp_pvar->type !=
PVT_SCRIPTVAR) ) {
+ LM_ERR("read_sdp_pv: not a valid AVP or VAR definition <%.*s>\n",
+ read_sdp_pvar_str.len, read_sdp_pvar_str.s);
+ return -1;
+ }
+ }
+
if (rtpp_strings)
pkg_free(rtpp_strings);
@@ -1780,6 +1794,7 @@ static bencode_item_t *rtpp_function_call(bencode_buffer_t *bencbuf,
struct sip_
int ret, queried_nodes;
struct rtpp_node *node;
char *cp;
+ pv_value_t pv_val;
/*** get & init basic stuff needed ***/
@@ -1810,7 +1825,16 @@ static bencode_item_t *rtpp_function_call(bencode_buffer_t
*bencbuf, struct sip_
ng_flags.replace = bencode_list(bencbuf);
ng_flags.rtcp_mux = bencode_list(bencbuf);
- if (extract_body(msg, &body) == -1) {
+ if (read_sdp_pvar!= NULL) {
+ if (read_sdp_pvar->getf(msg,&read_sdp_pvar->pvp, &pv_val) < 0)
+ {
+ LM_ERR("error getting pvar value <%.*s>\n", read_sdp_pvar_str.len,
read_sdp_pvar_str.s);
+ goto error;
+ } else {
+ body = pv_val.rs;
+ }
+
+ } else if (extract_body(msg, &body) == -1) {
LM_ERR("can't extract body from the message\n");
goto error;
}