Hello,
following the irc devel meeting discussions, I removed most of cfg compat stuff, the only remaining one is avp name parameters for TM. - for K mode expect: '$avp(name)' - for S mode expects: 'name'
The tracker item #2 is opened by Jan for it: http://sip-router.org/tracker/index.php?do=details&task_id=2
Now, shall I make it default the format $avp(..)? or keep both modes as: - if starts with pv marker '$', then parse as PV - otherwise parse as avp name string
Afterwards nothing will be controlled by cfg compat mode.
Cheers, Daniel
Daniel-Constantin Mierla writes:
Now, shall I make it default the format $avp(..)? or keep both modes as:
- if starts with pv marker '$', then parse as PV
- otherwise parse as avp name string
i vote for $avp() format. it is not a big thing for me to make the config change. just produce an error message if parameter does not start with $.
-- juha
On Apr 17, 2010 at 14:11, Daniel-Constantin Mierla miconda@gmail.com wrote:
Hello,
following the irc devel meeting discussions, I removed most of cfg compat stuff, the only remaining one is avp name parameters for TM.
- for K mode expect: '$avp(name)'
- for S mode expects: 'name'
The tracker item #2 is opened by Jan for it: http://sip-router.org/tracker/index.php?do=details&task_id=2
Now, shall I make it default the format $avp(..)? or keep both modes as:
- if starts with pv marker '$', then parse as PV
and if not found try avp (the same as for everything else).
- otherwise parse as avp name string
Maybe we should add also a warning that this is obsolete and t_set_fr() should be used instead.
Andrei
On 4/19/10 10:05 AM, Andrei Pelinescu-Onciul wrote:
On Apr 17, 2010 at 14:11, Daniel-Constantin Mierlamiconda@gmail.com wrote:
Hello,
following the irc devel meeting discussions, I removed most of cfg compat stuff, the only remaining one is avp name parameters for TM.
- for K mode expect: '$avp(name)'
- for S mode expects: 'name'
The tracker item #2 is opened by Jan for it: http://sip-router.org/tracker/index.php?do=details&task_id=2
Now, shall I make it default the format $avp(..)? or keep both modes as:
- if starts with pv marker '$', then parse as PV
and if not found try avp (the same as for everything else).
- otherwise parse as avp name string
Maybe we should add also a warning that this is obsolete and t_set_fr() should be used instead.
added the warning and for now changed cfg compat dependecy of using either avp pv spec or avp name format with auto-detection based on pv marker.
Cheers, Daniel
-
Andrei Pelinescu-Onciul -
Daniel-Constantin Mierla -
jh＠tutpro.com