#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3257
#### Description Do not build python2 module with default APKBUILD file due to python2 being sunsetted within Alpine Linux (there is no python2 APK).
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3258
-- Commit Summary --
* APKBUILD: remove python2 references
-- File Changes --
M pkg/kamailio/alpine/APKBUILD (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3258.patch https://github.com/kamailio/kamailio/pull/3258.diff
Thank for the PR - looks good to me. Lets wait a bit for more feedback and then merge it.
The Alpine automatic build does not work now. Required refactoring after Docker Hub closed the CI-builds on the free accounts. A thing required to write an automatic Alpine build using GitHub actions.
Let's write alpine automatic builds during the next mouth. If this does not happen, then we can merge.
The Alpine automatic build does not work now. Required refactoring after Docker Hub closed the CI-builds on the free accounts. A thing required to write an automatic Alpine build using GitHub actions.
Let's write alpine automatic builds during the next mouth. If this does not happen, then we can merge.
A few follow up questions on that:
1. Just so I understand correctly: You're referencing the apk binaries that get push to the official Alpine Linux repos, correct? Are you handling this / is any assistance, etc. needed? 2. This issue will probably need to be addressed first (or at least in conjunction) since even if your CI code was correct, build will fail due to inability to provide the depenancies, right?
With that said, this is far from a critical issue, so i see no reason to rush it either.
Just so I understand correctly: You're referencing the apk binaries that get push to the official Alpine Linux repos, correct? Are you handling this / is any assistance, etc. needed?
No, we push apk to the docker hub image. and then this maybe utilized using docker or k8s.
This issue will probably need to be addressed first (or at least in conjunction) since even if your CI code was correct, build will fail due to inability to provide the depenancies, right?
This will fail on thresh Alpine release. But we implement GitHub actions using the old Alpine release with the current packaging script. And then update the release and fix python2.
There seems to be no more progress related to the CI topic discussion. As there is no python2 anymore available on alpline, I will merge it. We also excluded already the app_python module from newer debian distributions (e.g. bookwork) build.
Merged #3258 into master.
-
Ben Kaufman -
Henning Westerholt
-
sergey-safarov