Module: sip-router Branch: master Commit: 321575dcd18e42fe6c62942ef417dd8acf7f466d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=321575dc...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: Thu Oct 2 10:18:11 2014 +0200
mohqueue: fixed db_qtable parameter name
- reported by Marino Mileti
---
modules/mohqueue/mohq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/mohqueue/mohq.c b/modules/mohqueue/mohq.c index 30c0c94..0a16606 100644 --- a/modules/mohqueue/mohq.c +++ b/modules/mohqueue/mohq.c @@ -70,7 +70,7 @@ int moh_maxcalls = 50; static param_export_t mod_parms [] = { { "db_url", PARAM_STR, &db_url }, { "db_ctable", PARAM_STR, &db_ctable }, - { "db_ctable", PARAM_STR, &db_qtable }, + { "db_qtable", PARAM_STR, &db_qtable }, { "mohdir", PARAM_STRING, &mohdir }, { "moh_maxcalls", INT_PARAM, &moh_maxcalls }, { NULL, 0, NULL },
Daniel,
I was wondering why this change was made. Is there a conflict with another value?
Bob
On Thu, Oct 2, 2014 at 4:20 AM, Daniel-Constantin Mierla miconda@gmail.com wrote:
Module: sip-router Branch: master Commit: 321575dcd18e42fe6c62942ef417dd8acf7f466d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=321575dc...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: Thu Oct 2 10:18:11 2014 +0200
mohqueue: fixed db_qtable parameter name
- reported by Marino Mileti
modules/mohqueue/mohq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/mohqueue/mohq.c b/modules/mohqueue/mohq.c index 30c0c94..0a16606 100644 --- a/modules/mohqueue/mohq.c +++ b/modules/mohqueue/mohq.c @@ -70,7 +70,7 @@ int moh_maxcalls = 50; static param_export_t mod_parms [] = { { "db_url", PARAM_STR, &db_url }, { "db_ctable", PARAM_STR, &db_ctable },
- { "db_ctable", PARAM_STR, &db_qtable },
- { "db_qtable", PARAM_STR, &db_qtable }, { "mohdir", PARAM_STRING, &mohdir }, { "moh_maxcalls", INT_PARAM, &moh_maxcalls }, { NULL, 0, NULL },
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
This looks like a typo fix.
2014-10-02 16:38 GMT+04:00 Robert Boisvert rdboisvert@gmail.com:
Daniel,
I was wondering why this change was made. Is there a conflict with another value?
Bob
On Thu, Oct 2, 2014 at 4:20 AM, Daniel-Constantin Mierla < miconda@gmail.com> wrote:
Module: sip-router Branch: master Commit: 321575dcd18e42fe6c62942ef417dd8acf7f466d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=321575dc...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: Thu Oct 2 10:18:11 2014 +0200
mohqueue: fixed db_qtable parameter name
- reported by Marino Mileti
modules/mohqueue/mohq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/mohqueue/mohq.c b/modules/mohqueue/mohq.c index 30c0c94..0a16606 100644 --- a/modules/mohqueue/mohq.c +++ b/modules/mohqueue/mohq.c @@ -70,7 +70,7 @@ int moh_maxcalls = 50; static param_export_t mod_parms [] = { { "db_url", PARAM_STR, &db_url }, { "db_ctable", PARAM_STR, &db_ctable },
- { "db_ctable", PARAM_STR, &db_qtable },
- { "db_qtable", PARAM_STR, &db_qtable }, { "mohdir", PARAM_STRING, &mohdir }, { "moh_maxcalls", INT_PARAM, &moh_maxcalls }, { NULL, 0, NULL },
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Robert,
the change is:
{ "db_ctable", PARAM_STR, &db_ctable }, - { "db_ctable", PARAM_STR, &db_qtable }, + { "db_qtable", PARAM_STR, &db_qtable },
Practically is changing c in q for the name of the parameter to set the db_qtable variable. Otherwise there are two db_ctable parameters defined, no option to set the db_qtable. The readme is mentioning db_qtable parameter, as reported by someone on sr-users list.
Daniel
On 02/10/14 14:38, Robert Boisvert wrote:
Daniel,
I was wondering why this change was made. Is there a conflict with another value?
Bob
On Thu, Oct 2, 2014 at 4:20 AM, Daniel-Constantin Mierla <miconda@gmail.com mailto:miconda@gmail.com> wrote:
Module: sip-router Branch: master Commit: 321575dcd18e42fe6c62942ef417dd8acf7f466d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=321575dcd18e42fe6c62942ef417dd8acf7f466d Author: Daniel-Constantin Mierla <miconda@gmail.com <mailto:miconda@gmail.com>> Committer: Daniel-Constantin Mierla <miconda@gmail.com <mailto:miconda@gmail.com>> Date: Thu Oct 2 10:18:11 2014 +0200 mohqueue: fixed db_qtable parameter name - reported by Marino Mileti --- modules/mohqueue/mohq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/mohqueue/mohq.c b/modules/mohqueue/mohq.c index 30c0c94..0a16606 100644 --- a/modules/mohqueue/mohq.c +++ b/modules/mohqueue/mohq.c @@ -70,7 +70,7 @@ int moh_maxcalls = 50; static param_export_t mod_parms [] = { { "db_url", PARAM_STR, &db_url }, { "db_ctable", PARAM_STR, &db_ctable }, - { "db_ctable", PARAM_STR, &db_qtable }, + { "db_qtable", PARAM_STR, &db_qtable }, { "mohdir", PARAM_STRING, &mohdir }, { "moh_maxcalls", INT_PARAM, &moh_maxcalls }, { NULL, 0, NULL }, _______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org <mailto:sr-dev@lists.sip-router.org> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Daniel,
I see the problem.
Thanks for correcting, Bob
On Thu, Oct 2, 2014 at 8:56 AM, Daniel-Constantin Mierla miconda@gmail.com wrote:
Robert,
the change is:
{ "db_ctable", PARAM_STR, &db_ctable },
- { "db_ctable", PARAM_STR, &db_qtable },
- { "db_qtable", PARAM_STR, &db_qtable },
Practically is changing c in q for the name of the parameter to set the db_qtable variable. Otherwise there are two db_ctable parameters defined, no option to set the db_qtable. The readme is mentioning db_qtable parameter, as reported by someone on sr-users list.
Daniel
On 02/10/14 14:38, Robert Boisvert wrote:
Daniel,
I was wondering why this change was made. Is there a conflict with another value?
Bob
On Thu, Oct 2, 2014 at 4:20 AM, Daniel-Constantin Mierla < miconda@gmail.com> wrote:
Module: sip-router Branch: master Commit: 321575dcd18e42fe6c62942ef417dd8acf7f466d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=321575dc...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: Thu Oct 2 10:18:11 2014 +0200
mohqueue: fixed db_qtable parameter name
- reported by Marino Mileti
modules/mohqueue/mohq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/mohqueue/mohq.c b/modules/mohqueue/mohq.c index 30c0c94..0a16606 100644 --- a/modules/mohqueue/mohq.c +++ b/modules/mohqueue/mohq.c @@ -70,7 +70,7 @@ int moh_maxcalls = 50; static param_export_t mod_parms [] = { { "db_url", PARAM_STR, &db_url }, { "db_ctable", PARAM_STR, &db_ctable },
- { "db_ctable", PARAM_STR, &db_qtable },
- { "db_qtable", PARAM_STR, &db_qtable }, { "mohdir", PARAM_STRING, &mohdir }, { "moh_maxcalls", INT_PARAM, &moh_maxcalls }, { NULL, 0, NULL },
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierlahttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-
Alekzander Spiridonov -
Daniel-Constantin Mierla -
Robert Boisvert