0xffffffff00000000ULL mask does not take into consideration signed 32 bit integers and as result 2147483648 will be stored as -2147483648. Another mask should be used to correct the issue: 0xffffffff80000000ULL. It processes correctly the case of integers that are greater than 2147483647.
There are several gdb tests below: (gdb) p ((unsigned long long)2147483648 & 0xffffffff80000000ULL) $1= 2147483648 (gdb) p ((unsigned long long)2147483647 & 0xffffffff80000000ULL) $2 = 0 (gdb) p ((unsigned long long)2147483646 & 0xffffffff80000000ULL) $3 = 0 (gdb) p ((unsigned long long)4147483646 & 0xffffffff80000000ULL) $4 = 2147483648
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2106
-- Commit Summary --
* lib: big integers should not be treated as negative ones
-- File Changes --
M src/lib/srdb1/db_ut.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2106.patch https://github.com/kamailio/kamailio/pull/2106.diff
I am not sure about the right way to deal in this case. Because also the very high unsigned int values will be negative in a pv value (which is signed int). Maybe adding a global parameter to control this is better than just changing the existing behaviour. The value of a pv can be retrieved in an embedded script (e.g., Lua, JS) and casted to unsigned int, if one knows that should be that kind of value. By the new mask you introduce, practically the unsigned int values are truncated to half of the range.
You are right in the observation. The fix is not ideal and the string representation will be used for integers that are greater than 2147483647. From other side the string representation will be definitely used for any ints that are greater than 4294967295. Thus the fix can lead to a performance degradation for values between 2147483647 and 4294967296 if the integer is **explicitly** interpreted as unsigned. That is a rare case. Please correct me if I am wrong there.
From another side the current behaviour is completely wrong if the result is not **explicitly** interpreted as unsigned. For instance 2 different integers 2626734008 and -1668233288 will be stored as -1668233288 and the negative value (-1668233288) will be used as pv. I.e. any value in the range (2147483647, 4294967296) will be stored and interpreted as a negative integer. This leads to a strange service behaviour in my case.
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
@miconda There have been several changes to core and also PVs (like AVP, XAVPs etc..) to use now internally long instead of int. Do you think it would make sense now to address this DB library topic?
Pushed a different commit now that pv number field is long.
Closed #2106.
-
Daniel-Constantin Mierla -
github-actions[bot]
-
Henning Westerholt
-
Ivan Murashko