Thanks!

I wonder if we should make a dedicated folder for oracle distro, like pkg/kamailio/oracle/. The pkg/kamailio/rpm/ tried to collect the generic ones, but proved over the time that each distro has its own specifics. Perhaps it needs to be split into a folder with opensuse specs, then remove. Centos has already its own folder, as well as fedora.

What do you think?

--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/588#issuecomment-215381599

Thanks! I applied the combined patches manually in order to format the commit messages as per guidelines:

* https://www.kamailio.org/wiki/devel/github-contributions#commit_message_form...

It the future would be good to format the commit message of your patches based on the guidelines to make the merge straightforward. We use the commit messages for logs and we try to keep them coherent in format and consistent in description.

Should other files from rpm folder be copied to the new oracle folder (e.g., init.d script), in order to make building the rpms without need to do manual copy at the build time?

I am not using rpm-based distro for quite many years, so I am not familiar with mock tool, but if you get the scripts/specs for mock, we can create a folder rpm-mock and host them there inside the kamailio git repo.

--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/588#issuecomment-215561489

Ok. I see.

--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/588#issuecomment-215622965