Hello,
can you check the pull request for mohqueue module at: - https://github.com/kamailio/kamailio/pull/71
It would be good to merge it asap, eventually get those end of lines for log messages even in 4.2 branch.
Cheers, Daniel
Daniel,
I'm not able to handle it this week but I will work on it next week.
Sorry, Bob
On Tue, Feb 10, 2015 at 4:08 AM, Daniel-Constantin Mierla <miconda@gmail.com
wrote:
Hello,
can you check the pull request for mohqueue module at:
It would be good to merge it asap, eventually get those end of lines for log messages even in 4.2 branch.
Cheers, Daniel
-- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, May 27-29, 2015 Berlin, Germany - http://www.kamailioworld.com
Daniel,
I looked over the changes and they are minor, mostly cosmetic and not functional. My present code has progressed beyond this point so it would take me more time than I'm willing to invest to merge these changes back in and verify them. I assume Ollie tested them for accuracy and functionality, so if you feel there is no risk you can merge them in to the current master.
Thanks, Bob
On Wed, Feb 11, 2015 at 8:21 AM, Robert Boisvert rdboisvert@gmail.com wrote:
Daniel,
I'm not able to handle it this week but I will work on it next week.
Sorry, Bob
On Tue, Feb 10, 2015 at 4:08 AM, Daniel-Constantin Mierla < miconda@gmail.com> wrote:
Hello,
can you check the pull request for mohqueue module at:
It would be good to merge it asap, eventually get those end of lines for log messages even in 4.2 branch.
Cheers, Daniel
-- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, May 27-29, 2015 Berlin, Germany - http://www.kamailioworld.com
Yes, as I said the changes seemed minor - besides closing the open items on the tracker, I was being mostly interested in getting end of line for the LOG messages. I will merge it then.
Thanks, Daniel
On 17/02/15 22:41, Robert Boisvert wrote:
Daniel,
I looked over the changes and they are minor, mostly cosmetic and not functional. My present code has progressed beyond this point so it would take me more time than I'm willing to invest to merge these changes back in and verify them. I assume Ollie tested them for accuracy and functionality, so if you feel there is no risk you can merge them in to the current master.
Thanks, Bob
On Wed, Feb 11, 2015 at 8:21 AM, Robert Boisvert <rdboisvert@gmail.com mailto:rdboisvert@gmail.com> wrote:
Daniel, I'm not able to handle it this week but I will work on it next week. Sorry, Bob On Tue, Feb 10, 2015 at 4:08 AM, Daniel-Constantin Mierla <miconda@gmail.com <mailto:miconda@gmail.com>> wrote: Hello, can you check the pull request for mohqueue module at: - https://github.com/kamailio/kamailio/pull/71 It would be good to merge it asap, eventually get those end of lines for log messages even in 4.2 branch. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda <http://twitter.com/#%21/miconda> - http://www.linkedin.com/in/miconda Kamailio World Conference, May 27-29, 2015 Berlin, Germany - http://www.kamailioworld.com