<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #1848
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1849
-- Commit Summary --
* topos_redis: fix branch insert expire duration
-- File Changes --
M src/modules/topos_redis/topos_redis_storage.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1849.patch https://github.com/kamailio/kamailio/pull/1849.diff
@jchavanton pushed 1 commit.
cf70716afc9cfff4ba8ab0e75e9c6364f2874393 topos: end dialog only when processing BYE method
The commit 728bbc4 does not seem right, it is setting branch expire to the dialog value, which is not correct.
As for commit cf70716 -- the tps_storage_end_dialog() has a check inside to be executed only for BYE:
* https://github.com/kamailio/kamailio/blob/master/src/modules/topos_redis/top...
Can you check if you have the same code base, give that you said you run some custom version.
If you have it, then maybe the issue is somewhere else, not setting properly the method id in the structure.
After double checking the code base I am missing a few old commits ...
Sorry, I made a mistake when checking initially, I will test with the right source code.
And update the issue.
These modifications are not needed, the related issue does not exist on the latest master branch.
Closed #1849.