* Fix for buffer overflow in enum_pv_query_3 for char string[17] where the boundary checks for it in is_e164 uses MAX_NUM_LEN.
* Increased the size of MAX_NUM_LEN to 33 to support the maximum number length of 32, which is what we support here on our ISUP links.
Bug: The buffer overflow bug can be triggered by calling enum_pv_query with a number that is to long eg. +1234567890123456789 You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/186
-- Commit Summary --
* * Fix for buffer overflow in enum_pv_query_3 for char string[17] where the boundary checks for it in is_e164 uses MAX_NUM_LEN.
-- File Changes --
M modules/enum/enum.c (4) M modules/enum/enum.h (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/186.patch https://github.com/kamailio/kamailio/pull/186.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/186
Going to merge it.
For the future, format the commit message based on suggestions at:
* http://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message
Thanks
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/186#issuecomment-108276583
Ahh, actually the commit message is properly formatted. Ignore my previous note.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/186#issuecomment-108277440
Merged #186.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/186#event-320972084
Ok, thank you for merging the fix.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/186#issuecomment-108290518
-
Daniel-Constantin Mierla -
Stefan Andersson