<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2593
#### Description <!-- Describe your changes in detail --> This PR removes the `dlg_flag` from the dialog module and recommends `dlg_manage()` instead in the docs. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3961
-- Commit Summary --
* dialog: Drop support for dlg_flag parameter * dialog/doc: Remove dlg_flag docs and suggest dlg_manage() instead.
-- File Changes --
M src/modules/dialog/dialog.c (13) M src/modules/dialog/dlg_handlers.c (22) M src/modules/dialog/dlg_handlers.h (3) M src/modules/dialog/doc/dialog_admin.xml (24)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3961.patch https://github.com/kamailio/kamailio/pull/3961.diff
Fine for me over all, I hope it does not impact other modules depending on dialog.
Thanks for the PR. There are several modules that seems to related to the dlg_flag:
* nat_traversal * call_control * cnxx * acc * qos * sst * pua_dialoginfo * mediaproxy * different IMS modules (ims_dialog will be not changed in this PR)
Some of the modules are using it only to check if there is a dialog module available. So this is probably not critical. But it needs to be investigated and probably changed. Some of the modules are just documenting it.
@xkaraman pushed 3 commits.
d6ec3112cda5c0709822960005adcc0a13766f06 acc: Remove dlg_flag docs 60d42baffeef4207be9409e191abe5119f29b8c1 qos: Remove dlg_flag docs a861f990f2e47825c830df75329fd01836716279 pua_dialoginfo: Remove dlg_flag docs
@xkaraman pushed 1 commit.
1715ca6da25985577eed0890d8b23904a936f097 sst: Remove dlg_flag docs
Only mention in the docs and no source code implications: 1. acc 2. qos 3. pua_dialoginfo 4. sst
The rest should require a separate PR probably
@xkaraman pushed 3 commits.
843b2900659e66ea972b8888fb319f364de25211 qos: Remove dlg_flag docs c875dc294dac23d4ef40a85481f682fe34b0dc61 pua_dialoginfo: Remove dlg_flag docs 212c51472fef984e37d9b5fb76dab16e63657d78 sst: Remove dlg_flag docs
The rest should require a separate PR probably
I would add all related changes here so it's clear what was needed to be done when removing the flag
@xkaraman pushed 10 commits.
a5c73520be51c684689c89df60b5c846c1e2f5fa dialog: Drop support for dlg_flag parameter d0e7bf68179e6111478d36e2e438fbe5ab42a891 dialog/doc: Remove dlg_flag docs and suggest dlg_manage() instead. 4ee6c8368113011b3fa4b2b5daa38254dc255c60 acc: Remove dlg_flag docs ab072a735be01863d5891e16c198048e2d3af107 qos: Remove dlg_flag docs 0169e663279c2a7f93145df7bdd25eacb7895e45 pua_dialoginfo: Remove dlg_flag docs 3a731e4a85f7a3fda112b87d43ba86d2856ada71 sst: Remove dlg_flag docs c1b28215e65026bcaeebe760aef9a5a403c7bbc4 call_control: Remove dlg_flag and update docs e1e242f17bbc49a41aba210858db89548aa256ab cnxcc: Remove dlg_flag and update docs 191881a83c0297cb35e61da68a6d36b3174f13da mediaproxy: Remove dlg_flag and update docs 06f874dfeb1a47f6ad087a96e125dbcb1387d6eb nat_traversal: Remove dlg_flag and update docs
@xkaraman pushed 1 commit.
f5b8c2898421cc6f28edc514a24a4819a1fdf7a6 nat_traversal: Remove dlg_flag and update docs
For the rest of modules: 1. call_control 2. cnxcc 3. mediaproxy 4. nat_traversal
The dialog flag reading and checking was removed for the above modules.
Also, the setting of the message internal flag was removed and updated docs that they MUST call `dlg_manage()` if they want the the functionality of tracking the call.
If there aren't any more reviews, this can probably be merged!
Merged #3961 into master.
Thanks, it was merged. Please send a short e-mail to sr-users list that the dialog flag was removed and list the affected modules.