This module provides db api interface to redis database
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1422
-- Commit Summary --
* Modules: db_redis for usrloc module
-- File Changes --
A src/modules/db_redis/Makefile (36) A src/modules/db_redis/README (89) A src/modules/db_redis/db_redis.c (100) A src/modules/db_redis/doc/Makefile (4) A src/modules/db_redis/doc/db_redis.xml (45) A src/modules/db_redis/doc/db_redis_admin.xml (86) A src/modules/db_redis/redisdb_base.c (1189) A src/modules/db_redis/redisdb_connection.c (100) A src/modules/db_redis/redisdb_connection.h (43) A src/modules/db_redis/redisdb_dbase.h (96)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1422.patch https://github.com/kamailio/kamailio/pull/1422.diff
@agranig @miconda
Vadiml1024 requested changes on this pull request.
I would suggest some rework:
This code contains potential reentrancy problems because of strtok usage... should be using strtok_r
In lot of places it uses sprintf, strcat, and strcpy which are subject to potential buffer overflows
in some places i see snprintf where source string size is passed as 2 parameter (buffer size). The idea is to pass target buffer size as second parameter
@Vadiml1024 first of all thank you for review .
will you please help me out by reentrancy by producing it ? because we tested it for more than 300 rps and with 70000 endpoint. we didn't face this issue.anyway its good if you can point me to specific case.
in some places i see snprintf where source string size is passed as 2 parameter (buffer size). The idea is to pass target buffer size as second parameter ???? will you please point out these places.
The module is very tight to usrloc module, embedding even the default column names for location table. If this is going to be merge in this state, I would suggest to name it like `db_redisuloc` or something else that suggests the constraints with its usage. Later can be renamed.
Regarding the issue with snprintf size parameter reported above, I spotted like:
``` return_code = snprintf(table_name,(CON_TABLE(_h)->len+1) * sizeof(char),"%s%.*s%s",CON_TQUOTESZ(_h), CON_TABLE(_h)->len, CON_TABLE(_h)->s, CON_TQUOTESZ(_h)); ``` Another aspect that needs to be take care is to check if pkg_malloc() returns NULL or not -- if there is no sufficient memory, it will cause a crash.
@SurendraPlivo pushed 1 commit.
0061e2b rename to db_redisusrloc
@SurendraPlivo pushed 1 commit.
13608cc rename to db_redisusrloc
Closed #1422.
-
Daniel-Constantin Mierla -
Surendra Tiwari
-
Vadiml1024