- Adding missing ims_icscf database parameters to admin documents. - Change the default value for ims_icscf db_url to Kamailio default db_url value.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ :white_check_mark: ] Commit message has the format required by CONTRIBUTING guide - [ :white_check_mark:] Commits are split per component (core, individual modules, libs, utils, ...) - [ :white_check_mark:] Each component has a single commit (if not, squash them into one commit) - [ :white_check_mark:] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ :white_check_mark:] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ :white_check_mark:] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Only an improvement for users to know they need to set database params for ims_icscf module.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3874
-- Commit Summary --
* ims_icscf: add missing documents for database params
-- File Changes --
M src/modules/ims_icscf/doc/ims_icscf_admin.xml (100) M src/modules/ims_icscf/ims_icscf_mod.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3874.patch https://github.com/kamailio/kamailio/pull/3874.diff
@hyavari pushed 1 commit.
b224365fc8c47593b92d220379c121fba5b8e4b3 ims_usrloc_pcscf: Update the module document
@henningw commented on this pull request.
Thanks for the PR, I have added two comments related to the usage of database URLs.
@@ -71,7 +71,7 @@ stat_var *uar_replies_response_time = NULL;
stat_var *lir_replies_response_time = NULL;
//module parameters -char *ims_icscf_db_url = "mysql://icscf:heslo@localhost/hssdata"; /**< DB URL */ +char *ims_icscf_db_url = "mysql://kamailio:kamailiorw@localhost/kamailio"; /**< DB URL */
Consider using the correct define for it: DEFAULT_RODB_URL
<para>
+ If the db_url string is empty, the default database URL + will be used. + </para> + + <para> + <emphasis> + Default value is <quote>&defaultrodb;</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_url</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_url", "mysql://username:password@localhost/kamailio")
You could use also here the definition "&exampledb;
@hyavari pushed 2 commits.
8cf47268d499343b0f2dc8c9344aae7d9d9572bb ims_icscf: add missing documents for database params 1efac37dec887aaac7c47dee03ae05c592983d0d ims_usrloc_pcscf: Update the module document
@hyavari commented on this pull request.
@@ -71,7 +71,7 @@ stat_var *uar_replies_response_time = NULL;
stat_var *lir_replies_response_time = NULL;
//module parameters -char *ims_icscf_db_url = "mysql://icscf:heslo@localhost/hssdata"; /**< DB URL */ +char *ims_icscf_db_url = "mysql://kamailio:kamailiorw@localhost/kamailio"; /**< DB URL */
Thanks, I resolved it.
@hyavari commented on this pull request.
<para>
+ If the db_url string is empty, the default database URL + will be used. + </para> + + <para> + <emphasis> + Default value is <quote>&defaultrodb;</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_url</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_url", "mysql://username:password@localhost/kamailio")
Thanks, I applied it.
Merged #3874 into master.