Hello,
I have added pipeline support to the ndb_redis_module. Two functions are added: -redis_pipe_cmd which appends a command to be pipelined(syntax is identical with redis_cmd) -redis_execute which sends one message with all existing pipelined commands and handles the replies
To send multiple commands in a single message, the user must call redis_pipe_cmd for each command, and then redis_execute to send all messages.
This enhancement is not compatible with the recently added REDIS cluster support, so if that is enabled the new functions don't do anything but log an error.
Thanks, Claudiu Boriga You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1079
-- Commit Summary --
* ndb_redis: add pipeline suppport for REDIS Module
-- File Changes --
M src/modules/ndb_redis/doc/ndb_redis_admin.xml (87) M src/modules/ndb_redis/ndb_redis_mod.c (255) M src/modules/ndb_redis/redis_client.c (190) M src/modules/ndb_redis/redis_client.h (23)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1079.patch https://github.com/kamailio/kamailio/pull/1079.diff
Pinging Carsten (@ngvoice) -- is it needed to wait for fixing the changes done by using shm memory or this PR can be merged?
@claudiupb - can you resolve the conflicts so this PR can be merged? The module was in a broken state at the time you did the PR, which needed to be fixed, sorry for the extra work.
Ok, I will resolve the conflicts
@claudiupb pushed 1 commit.
f3a00aa Merge branch 'master' into redis_pipeline
@claudiupb pushed 1 commit.
83c68c5 fix indentation
I resolved the conflicts in the PR.
@claudiupb - the travis-ci is reporting compilation errors with the patches, see the details the post above.
@claudiupb pushed 1 commit.
3f696ae fix compilation error
Hello, there was a problem because _redisc_srv_list type was modified.
Thanks, I merged it manually to get rid of the extra commit messages that didn't follow the required format -- commit ff8cfa62c41704b72301966b0919ea95b001dac7 .
Closed #1079.