[tracker] Comment added: textops: add functions to convert and append multipart bodies. (Attachment added)
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#410 - textops: add functions to convert and append multipart bodies. User who did this - Víctor Seva (linuxmaniac)
---------- Crashes fixed. Flag version only added to build_req_buf_from_sip_req() for now.
Documentation added.
Any comments?
Should I push this to a tmp branch? ----------
One or more files have been attached.
More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=410#comment1...
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
sip-router writes:
Documentation added.
Any comments?
does this include a function to remove a body part from a multipart body and, if necessary, convert the body to non-multipart?
-- juha
Hi Juha,
2014-03-22 5:34 GMT+01:00 Juha Heinanen jh@tutpro.com:
Any comments?
does this include a function to remove a body part from a multipart body and, if necessary, convert the body to non-multipart?
No, it doesn't. Very good point. Starting to implement that.
Thanks, Victor
2014-03-22 7:33 GMT+01:00 Victor Seva linuxmaniac@torreviejawireless.org:
2014-03-22 5:34 GMT+01:00 Juha Heinanen jh@tutpro.com:
Any comments?
does this include a function to remove a body part from a multipart body and, if necessary, convert the body to non-multipart?
No, it doesn't. Very good point. Starting to implement that.
It seems that you can already convert to non-multipart using filter_body.
http://www.kamailio.org/docs/modules/devel/modules/textops.html#textops.f.fi...
... if (has_body("multipart/mixed")) { if (filter_body("application/sdp") { remove_hf("Content-Type"); append_hf("Content-Type: application/sdp\r\n"); } else { xlog("Body part application/sdp not found\n"); } } ...
Victor Seva writes:
It seems that you can already convert to non-multipart using filter_body.
http://www.kamailio.org/docs/modules/devel/modules/textops.html#textops.f.fi...
... if (has_body("multipart/mixed")) { if (filter_body("application/sdp") { remove_hf("Content-Type"); append_hf("Content-Type: application/sdp\r\n"); } else { xlog("Body part application/sdp not found\n"); } }
that assumes that i know what the remaining bodypart is, which is not quite the same thing as removing a known bodypart.
-- juha
2014-03-22 8:15 GMT+01:00 Juha Heinanen jh@tutpro.com:
that assumes that i know what the remaining bodypart is, which is not quite the same thing as removing a known bodypart.
This is just for convert to non-multipart. For removing I'm coding a remove_ function.
-
Juha Heinanen -
sip-router -
Victor Seva