[tracker] Comment added: textops: add functions to convert and append multipart bodies. (Attachment added)
21 Mar
2014
21 Mar
'14
11:10 p.m.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#410 - textops: add functions to convert and append multipart bodies.
User who did this - Víctor Seva (linuxmaniac)
----------
Crashes fixed. Flag version only added to build_req_buf_from_sip_req() for now.
Documentation added.
Any comments?
Should I push this to a tmp branch?
----------
One or more files have been attached.
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=410#comment…
You are receiving this message because you have requested it from the Flyspray bugtracking
system. If you did not expect this message or don't want to receive mails in future,
you can change your notification settings at the URL shown above.
22 Mar
22 Mar
6:34 a.m.
New subject: [tracker] Comment added: textops: add functions to convert and append multipart bodies. (Attachment added)
sip-router writes:
Documentation added.
Any comments?
does this include a function to remove a body part from a multipart body
and, if necessary, convert the body to non-multipart?
-- juha
8:33 a.m.
New subject: [tracker] Comment added: textops: add functions to convert and append multipart bodies. (Attachment added)
Hi Juha,
2014-03-22 5:34 GMT+01:00 Juha Heinanen <jh(a)tutpro.com>om>:
No, it doesn't. Very good point. Starting to implement that.
Thanks,
Victor
Any comments?
does this include a function to remove a body part from a multipart body
and, if necessary, convert the body to non-multipart?
8:53 a.m.
New subject: [tracker] Comment added: textops: add functions to convert and append multipart bodies. (Attachment added)
2014-03-22 7:33 GMT+01:00 Victor Seva <linuxmaniac(a)torreviejawireless.org>rg>:
2014-03-22 5:34 GMT+01:00 Juha Heinanen
<jh(a)tutpro.com>om>:
No, it doesn't. Very good point. Starting to implement that.
It seems that you can already convert to non-multipart using filter_body.
http://www.kamailio.org/docs/modules/devel/modules/textops.html#textops.f.f…
...
if (has_body("multipart/mixed")) {
if (filter_body("application/sdp") {
remove_hf("Content-Type");
append_hf("Content-Type: application/sdp\r\n");
} else {
xlog("Body part application/sdp not found\n");
}
}
...
Any
comments?
does this include a function to remove a body part from a multipart body
and, if necessary, convert the body to non-multipart?
9:15 a.m.
New subject: [tracker] Comment added: textops: add functions to convert and append multipart bodies. (Attachment added)
Victor Seva writes:
It seems that you can already convert to non-multipart
using filter_body.
http://www.kamailio.org/docs/modules/devel/modules/textops.html#textops.f.f…
...
if (has_body("multipart/mixed")) {
if (filter_body("application/sdp") {
remove_hf("Content-Type");
append_hf("Content-Type: application/sdp\r\n");
} else {
xlog("Body part application/sdp not found\n");
}
}
that assumes that i know what the remaining bodypart is, which is not
quite the same thing as removing a known bodypart.
-- juha
9:30 a.m.
New subject: [tracker] Comment added: textops: add functions to convert and append multipart bodies. (Attachment added)
2014-03-22 8:15 GMT+01:00 Juha Heinanen <jh(a)tutpro.com>om>:
that assumes that i know what the remaining bodypart
is, which is not
quite the same thing as removing a known bodypart.
This is just for convert to non-multipart. For removing I'm coding a
remove_ function.
3903
days inactive
3904
days old
5 comments
3 participants
participants (3)
-
Juha Heinanen -
sip-router -
Victor Seva