git:master:7fad9c51: app_sqlang: fix squirrel warning: ânArgsâ may be used uninitialized in this function
Module: kamailio Branch: master Commit: 7fad9c51f71854e0649fe76e273190e4b4f82438 URL: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4...
Author: Henning Westerholt hw@skalatan.de Committer: Henning Westerholt hw@skalatan.de Date: 2019-11-23T18:53:17+01:00
app_sqlang: fix squirrel warning: ânArgsâ may be used uninitialized in this function
---
Modified: src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp
---
Diff: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4... Patch: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4...
---
diff --git a/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp b/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp index f3b8103185..fb6545f921 100644 --- a/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp +++ b/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp @@ -625,7 +625,7 @@ static SQInteger __map_array(SQArray *dest,SQArray *src,HSQUIRRELVM v) { SQObject &closure = stack_get(v, 2); v->Push(closure);
- SQInteger nArgs; + SQInteger nArgs = 0; if(sq_type(closure) == OT_CLOSURE) { nArgs = _closure(closure)->_function->_nparameters; }
Hello,
this change has to be pushed to the upstream project, otheriwse with the next sync it is going to be lost -- we do not maintain the code of squirrel interpreter, it is used as an embedded library. The project is at:
* https://github.com/albertodemichelis/squirrel
Cheers, Daniel
On 23.11.19 18:54, Henning Westerholt wrote:
Module: kamailio Branch: master Commit: 7fad9c51f71854e0649fe76e273190e4b4f82438 URL: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4...
Author: Henning Westerholt hw@skalatan.de Committer: Henning Westerholt hw@skalatan.de Date: 2019-11-23T18:53:17+01:00
app_sqlang: fix squirrel warning: ‘nArgs’ may be used uninitialized in this function
Modified: src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp
Diff: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4... Patch: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4...
diff --git a/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp b/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp index f3b8103185..fb6545f921 100644 --- a/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp +++ b/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp @@ -625,7 +625,7 @@ static SQInteger __map_array(SQArray *dest,SQArray *src,HSQUIRRELVM v) { SQObject &closure = stack_get(v, 2); v->Push(closure);
- SQInteger nArgs;
- SQInteger nArgs = 0; if(sq_type(closure) == OT_CLOSURE) { nArgs = _closure(closure)->_function->_nparameters; }
Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Hi Daniel,
Upstream issue: https://github.com/albertodemichelis/squirrel/issues/205
Cheers,
Henning
-- Henning Westerholt – https://skalatan.de/blog/ Kamailio services – https://gilawa.comhttps://gilawa.com/ Kamailio Merchandising – https://skalatan.de/merchandising
From: Daniel-Constantin Mierla miconda@gmail.com Sent: Monday, November 25, 2019 11:11 AM To: Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org; Henning Westerholt hw@skalatan.de Subject: Re: git:master:7fad9c51: app_sqlang: fix squirrel warning: ânArgsâ may be used uninitialized in this function
Hello,
this change has to be pushed to the upstream project, otheriwse with the next sync it is going to be lost -- we do not maintain the code of squirrel interpreter, it is used as an embedded library. The project is at:
* https://github.com/albertodemichelis/squirrel
Cheers, Daniel
On 23.11.19 18:54, Henning Westerholt wrote:
Module: kamailio
Branch: master
Commit: 7fad9c51f71854e0649fe76e273190e4b4f82438
URL: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4...
Author: Henning Westerholt hw@skalatan.demailto:hw@skalatan.de
Committer: Henning Westerholt hw@skalatan.demailto:hw@skalatan.de
Date: 2019-11-23T18:53:17+01:00
app_sqlang: fix squirrel warning: ‘nArgs’ may be used uninitialized in this function
---
Modified: src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp
---
Diff: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4...
Patch: https://github.com/kamailio/kamailio/commit/7fad9c51f71854e0649fe76e273190e4...
---
diff --git a/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp b/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp
index f3b8103185..fb6545f921 100644
--- a/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp
+++ b/src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp
@@ -625,7 +625,7 @@ static SQInteger __map_array(SQArray *dest,SQArray *src,HSQUIRRELVM v) {
SQObject &closure = stack_get(v, 2);
v->Push(closure);
- SQInteger nArgs;
+ SQInteger nArgs = 0;
if(sq_type(closure) == OT_CLOSURE) {
nArgs = _closure(closure)->_function->_nparameters;
}
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.orgmailto:sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
--
Daniel-Constantin Mierla -- www.asipto.comhttp://www.asipto.com
www.twitter.com/micondahttp://www.twitter.com/miconda -- www.linkedin.com/in/micondahttp://www.linkedin.com/in/miconda
Kamailio World Conference - April 27-29, 2020, in Berlin -- www.kamailioworld.comhttp://www.kamailioworld.com
-
Daniel-Constantin Mierla -
Henning Westerholt