[kamailio/kamailio] pkg/kamailio: Fix of ticket 1085 (#1086)

List overview All Threads
Download

newer

older

git:master:cbaeb436: Revert "sl:...

git:master:158bfa4c: siputils:...

sergey-safarov

22 Apr 2017 22 Apr '17

2:40 p.m.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/1086

-- Commit Summary --

* pkg/kamailio: Fix of ticket 1085

-- File Changes --

M pkg/kamailio/centos/7/kamailio.service (2) M pkg/kamailio/deb/debian/kamailio.service (2) M pkg/kamailio/deb/jessie/kamailio.service (2) M pkg/kamailio/deb/sid/kamailio.service (2) M pkg/kamailio/deb/stretch/kamailio.service (2) M pkg/kamailio/deb/xenial/kamailio.service (2) M pkg/kamailio/fedora/17/kamailio.service (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1086.patch https://github.com/kamailio/kamailio/pull/1086.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086

Attachments:

attachment.html (text/html — 3.4 KB)

Show replies by date

Daniel-Constantin Mierla

22 Apr 22 Apr

4:25 p.m.

This commit message is not describing properly what it adds or fixes. You can add a reference to a bug report, but the commit must have proper description text of what it does. The commit messages are used to generate the changelog files for release. You have to update the commit message in order to get the pull request merged.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-296384499

sergey-safarov

5:57 p.m.

@miconda PR updated

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-296390459

Daniel-Constantin Mierla

24 Apr 24 Apr

9:20 a.m.

@linuxmaniac - are you ok with the changes proposed for deb packaging regarding the systemd?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-296591080

Victor Seva

9:28 a.m.

See my comment at https://github.com/kamailio/kamailio/issues/1085#issuecomment-296592791

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-296593042

Victor Seva

9:29 a.m.

What happens if you have a non-working config and you have `on-failure`? I would assume the daemon will be restarted forever

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-296593428

sergey-safarov

12:04 p.m.

@linuxmaniac yes, unit will be restarted infinity, Rate of restarts may limiter using "RestartSec" keyword

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-296640401

sergey-safarov

6:24 p.m.

@linuxmaniac we can also mark exit code for broken config as SuccessExitStatus. Than unit will not restart in case of broken config

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-296780645

sergey-safarov

29 Apr 29 Apr

2:27 p.m.

@linuxmaniac changes is not required. I updated kamailio config and now daemon cannot parse config. System unit not restart as exist `start-limit`

...

[root@aeyears kamailio]# systemctl status kamailio ● kamailio.service - Kamailio (OpenSER) - the Open Source SIP Server Loaded: loaded (/usr/lib/systemd/system/kamailio.service; enabled; vendor preset: disabled) Active: failed (Result: start-limit) since Sat 2017-04-29 10:20:45 EDT; 4min 50s ago Process: 99917 ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_MEMORY -M $PKG_MEMORY (code=exited, status=255) Main PID: 99614 (code=exited, status=0/SUCCESS)

Apr 29 10:20:44 aeyears.as50056.net systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. Apr 29 10:20:44 aeyears.as50056.net systemd[1]: Unit kamailio.service entered failed state. Apr 29 10:20:44 aeyears.as50056.net systemd[1]: kamailio.service failed. Apr 29 10:20:45 aeyears.as50056.net systemd[1]: kamailio.service holdoff time over, scheduling restart. Apr 29 10:20:45 aeyears.as50056.net systemd[1]: start request repeated too quickly for kamailio.service Apr 29 10:20:45 aeyears.as50056.net systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. Apr 29 10:20:45 aeyears.as50056.net systemd[1]: Unit kamailio.service entered failed state. Apr 29 10:20:45 aeyears.as50056.net systemd[1]: kamailio.service failed.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-298172203

Daniel-Constantin Mierla

15 May 15 May

6:20 p.m.

Any resolution on this? Is it breaking things and should be discarded or not?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-301560169

Daniel-Constantin Mierla

2 Jun 2 Jun

1:39 p.m.

@linuxmaniac - any spare time soon to review and decide what to do with this PR?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-305789900

Victor Seva

29 Jun 29 Jun

8:36 a.m.

I still don't see why we need this. What is the case of "non null exit"?

...

From my POV I only want kamailio service to restart if there was a segfault and AFAICT that is already happening with the actual systemd configuration

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-311900396

sergey-safarov

9:22 a.m.

When kamailio cannot allocate memory (no free memeory on host), then we got non null exit code.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-311911630

Daniel-Constantin Mierla

1 Aug 1 Aug

7:04 a.m.

Closed #1086.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#event-1187068255

Daniel-Constantin Mierla

7:04 a.m.

I am going to close this. Being interpretable, one can also do local chances of the systemd confs.

@linuxmaniac being the official maintainer of Kamailio debs inside Debian process has the final decision on maintaining those specs.

@sergey-safarov you can make a patch only for rpm specs and can be considered as a dedicated pull request.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-319286504

Florian Floimair

9 Oct 9 Oct

11:18 a.m.

@linuxmaniac Well, actually systemd does not restart Kamailio in case of segfault. Just verified this on my system (Debian 9 "stretch"). So I would really want this change merged. For now I manually changed my systemd configuration to "on-failure".

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1086#issuecomment-428154464

2370

Age (days ago)

2905

Last active (days ago)

sr-dev@lists.kamailio.org

15 comments

4 participants

tags (0)

participants (4)

Daniel-Constantin Mierla
Florian Floimair
sergey-safarov
Victor Seva