- [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2916
#### Description This update moves the nats urls into a `nats_connection_ptr` struct. This will allow the nats_urls to be extended into a linked-list (to allow simultaneous connections) while still maintaining nats built-in failover connectivity which comes included in the libnats
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2934
-- Commit Summary --
* nats: move nats connection handling into a struct in order to extend features
-- File Changes --
M src/modules/nats/nats_mod.c (248) M src/modules/nats/nats_mod.h (13)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2934.patch https://github.com/kamailio/kamailio/pull/2934.diff
Hi, my only comment is that when the nats server is down and kamailio is started, those 2 logs appear: ``` Nov 19 12:32:53 LXBU-GRPF8S2 kamailio: ERROR: nats [nats_mod.c:123]: nats_consumer_worker_proc(): could not connect to nats servers [Not Yet Connected] Nov 19 12:32:53 LXBU-GRPF8S2 kamailio: INFO: nats [nats_mod.c:159]: nats_consumer_worker_proc(): nats queue group worker connected to subject [foo] queue group [2020] ```
So maybe 2'nd log should be logged only when server is up. Otherwise, looks good to me.
Thanks, Stefan
@eschmidbauer pushed 1 commit.
ff852c46b3b8bee94f63a30974c0742b5829204d nats: move nats connection handling into a struct in order to extend features
Hi, my only comment is that when the nats server is down and kamailio is started, those 2 logs appear:
Nov 19 12:32:53 kamailio: ERROR: nats [nats_mod.c:123]: nats_consumer_worker_proc(): could not connect to nats servers [Not Yet Connected] Nov 19 12:32:53 kamailio: INFO: nats [nats_mod.c:159]: nats_consumer_worker_proc(): nats queue group worker connected to subject [foo] queue group [2020]
So maybe 2'nd log should be logged only when server is up. Otherwise, looks good to me.
Thanks, Stefan
Hi Stefan, thanks for the feedback. I have removed the log line since it was not accurate.
Merged #2934 into master.