- we can enable kamctl test by setting `KAMCTL_TEST=true kamctl` instead of setting TEST variable in kamctl script.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1977
-- Commit Summary --
* kamctl: enable kamctl test from shell variable.
-- File Changes --
M utils/kamctl/kamctl (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1977.patch https://github.com/kamailio/kamailio/pull/1977.diff
@alishir pushed 1 commit.
2c8fe55a2617892e129e613a5950bb8c0228f59e kamdbctl: change /bin/sh to /bin/bash
@alishir - what were the errors related to commit 2c8fe55? Stretch is out for long time, nobody reported the errors so far.
@miconda It causes `Substitution Error`. I search for that error and I found that the cause is that `sh` links to `dash` in Debian Stretch. I change the `/bin/sh` to `/bin/bash` and error resolved.
Can you paste the the command you run and the entire error message printed in the terminal to try to track it properly?
Unfortunately I have no access to that system now, I will revert the change and test again.
@miconda Here is the output of `kamdbctl create`: ```bash MySQL password for root: -e \E[37;33mINFO: creating database kamailio_simple_db ... -e \E[37;33mINFO: granting privileges to database kamailio_simple_db ... -e \E[37;33mINFO: creating standard tables into kamailio_simple_db ... -e \E[37;33mINFO: Core Kamailio tables succesfully created. Install presence related tables? (y/n): n /usr/sbin/kamdbctl: 216: /usr/sbin/kamdbctl: Bad substitution
```
I fear that applying 2c8fe55 will break compatibility for embedded systems again (issue #1815). Can you execute the kamdbctl create with 'bash -x' prefixed and see where exactly it stops? Maybe it is possible to just make this substitution to confirm to POSIX standard as well.
It seems that the issue is expanding the variable when getting the answer for y/n question: * https://github.com/kamailio/kamailio/blob/master/utils/kamctl/kamdbctl.base#...
Such expression seems to be specific for bash: * https://mywiki.wooledge.org/Bashism
We should decide what to do to have an acceptable solution. Or maybe focus to make kamcli a (full) replacement for kamctl/kamdbctl and get rid of those old-style shell/bash scripts.
I applied a slightly different patch for enabling test mode from command line, enclosing the variable in double quotes - 4968e8994157f1152bf7461b16049d67e5c9cc59 .
For the bash related problems, I will open a dedicated issue on tracker to decide on a proper solution.
Closed #1977.
-
Ali Shirvani -
Daniel-Constantin Mierla
-
Henning Westerholt