You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1089
-- Commit Summary --
* pkg/kamailio: Fixed systemd unit failure on server boot
-- File Changes --
M pkg/kamailio/centos/7/kamailio.service (2) M pkg/kamailio/fedora/17/kamailio.service (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1089.patch https://github.com/kamailio/kamailio/pull/1089.diff
Same as #1090?
I'm not sure you need After=network.target and network-online.target, but based on https://fedoraproject.org/wiki/Networking/Ideas/ServiceOrdering, you will want Wants=network-online.target
Please look https://github.com/kamailio/kamailio/pull/1104/files Think IP_FREEBIND is preferred implementation.
IP_FREEBIND is not going to be by default on, it is not present in many operating systems but also can expose to service failure due to unnoticed typos in ip addresses.
@amessina - are you ok merging this? I am not a centos user myself.
@miconda @sergey-safarov, I'm also not a CentOS user, but a Fedora user :) Still, according to https://fedoraproject.org/wiki/Networking/Ideas/ServiceOrdering, you need `Wants=network-online.target` since it is not enabled by default on RedHat based systems. Other than that, sure. The kamailio.service file I package is https://messinet.com/rpms/browser/kamailio/kamailio.service
@amessina updated PR - added "Wants" - added "Documentation"
I think that looks good.
Merging, thanks!
Merged #1089.
-
Anthony Messina -
Daniel-Constantin Mierla
-
sergey-safarov