<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Adding KDMQ replication for rtpengine hash table (call -> rtpengine instance assignment) You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4240
-- Commit Summary --
* rtpegnine hash table dmq replication
-- File Changes --
M src/modules/rtpengine/rtpengine.c (49) M src/modules/rtpengine/rtpengine.h (4) M src/modules/rtpengine/rtpengine_db.c (2) A src/modules/rtpengine/rtpengine_dmq.c (310) A src/modules/rtpengine/rtpengine_dmq.h (54)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4240.patch https://github.com/kamailio/kamailio/pull/4240.diff
@vlitvinov pushed 1 commit.
38a2243c4367b5a90800f829f67495c518fc7f49 rtpegnine: hash table dmq replication
@rfuchs commented on this pull request.
@@ -531,6 +533,7 @@ static param_export_t params[] = {
{"dtmf_event_source_tag", PARAM_STR, &dtmf_event_source_tag_pvar_str}, {"dtmf_event_timestamp", PARAM_STR, &dtmf_event_timestamp_pvar_str}, {"dtmf_event", PARAM_STR, &dtmf_event_pvar_str}, + {"enable_dmq", PARAM_INT, &rtpengine_enable_dmq},
Please add this to the documentation
@vlitvinov pushed 1 commit.
f5360202d6bc1e88aaae1fa0f4cc4aee6161e474 rtpengine: hash table dmq replication
@vlitvinov commented on this pull request.
@@ -531,6 +533,7 @@ static param_export_t params[] = {
{"dtmf_event_source_tag", PARAM_STR, &dtmf_event_source_tag_pvar_str}, {"dtmf_event_timestamp", PARAM_STR, &dtmf_event_timestamp_pvar_str}, {"dtmf_event", PARAM_STR, &dtmf_event_pvar_str}, + {"enable_dmq", PARAM_INT, &rtpengine_enable_dmq},
New module parameter was added to the documentation
@vlitvinov pushed 1 commit.
0b4cf3ee99a1c18b6f61934b248d1486a1b445ac rtpengine: hash table dmq replication
@oej commented on this pull request.
@@ -2419,6 +2419,31 @@ modparam("rtpengine", "ping_mode", 0)
<programlisting format="linespecific"> ... modparam("rtpengine", "ping_interval", 10) +... + </programlisting> + </example> +</section> + +<section id="rtpengine.p.enable_dmq"> + <title><varname>enable_dmq</varname> (integer)</title> + <para> + If set to 1, will enable DMQ replication of hashtable of (callid, node) pairs. + </para> + <para> + <emphasis> + Important: If this parameter is enabled, the DMQ module must be loaded first - otherwise, startup will fail.
Maybe change "first" to "before this module"
@vlitvinov commented on this pull request.
@@ -2419,6 +2419,31 @@ modparam("rtpengine", "ping_mode", 0)
<programlisting format="linespecific"> ... modparam("rtpengine", "ping_interval", 10) +... + </programlisting> + </example> +</section> + +<section id="rtpengine.p.enable_dmq"> + <title><varname>enable_dmq</varname> (integer)</title> + <para> + If set to 1, will enable DMQ replication of hashtable of (callid, node) pairs. + </para> + <para> + <emphasis> + Important: If this parameter is enabled, the DMQ module must be loaded first - otherwise, startup will fail.
This line was taken from other modules' docs such as htable or presence.
rfuchs left a comment (kamailio/kamailio#4240)
Fine with me although I don't know much about the DMQ module.
henningw left a comment (kamailio/kamailio#4240)
Thanks for the PR. I also had a look to the PR, it looked ok to me. As @rfuchs already reviewed as well, merged.
Merged #4240 into master.
Ken-UC left a comment (kamailio/kamailio#4240)
Hi thanks for this feature. Any idea when it will available on official release? 6.0.3? Regards
henningw left a comment (kamailio/kamailio#4240)
Hi thanks for this feature. Any idea when it will available on official release? 6.0.3? Regards
It will be included in the next major release, probably 6.1.0 end of this year or beginning of 2026.
-
Henning Westerholt -
Ken-UC
-
Olle E. Johansson
-
Richard Fuchs
-
vlitvinov