<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> This adds RPC command to view and/or change the timeout value for PDB queries. The documentation is also updated accordingly.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4254
-- Commit Summary --
* pdb: added rpc command to view/update the pdb query timeout * pdb: add documentation for rpc command to view/update the pdb query timeout
-- File Changes --
M src/modules/pdb/doc/pdb.xml (55) M src/modules/pdb/doc/pdb_admin.xml (334) M src/modules/pdb/pdb.c (49)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4254.patch https://github.com/kamailio/kamailio/pull/4254.diff
henningw left a comment (kamailio/kamailio#4254)
Thanks for the PR. I have noticed that you reformatted a lot of sections in the doc file, was this done intentionally? There are also other changes in the commit, like changing the log level of certain log messages, adding new log messages etc.. If this was also done intentionally, I would prefer to have it as dedicated commits as its not related to the RPC command addition.
mshary left a comment (kamailio/kamailio#4254)
I think this formatting was added by VIM editor since I have clang-formatting enabled globally for all C, C++ & Java files.
Regarding the new logs and log levels, they were intentional to scream out critical errors such a missing server list or bad file handle etc. during unit testing and Q.A etc. They are helpful but not directly related to PR.
I will remove these unnecessary changes and update the patch.
@mshary pushed 1 commit.
3a2bcd1a25c509e86bdb841cdfbf2ebf3ab387b6 pdb: removed unnecessary xml doc formatting for compliance with exiting code-base
@mshary pushed 1 commit.
e60385faa21aa94423af1125ccb73707b9fa0b78 pdb: removed unnecessary logging per PR feedback
mshary left a comment (kamailio/kamailio#4254)
all changes done per feedback, please review. Thank you.
miconda left a comment (kamailio/kamailio#4254)
I guess it is ok to merge.
Closed #4254.
henningw left a comment (kamailio/kamailio#4254)
@mshary Thanks for the changes, it looks fine. I just noticed that this PR wants to be merged into the stable branch, which is not appropriate. I have tried to change it in the PR, but it created a lot of conflicts unfortunately. Can you please re-create this PR against kamailio master branch? I will close this one to prevent it from merged into the wrong branch.