Use appropriate types for core values: -> start and end as dates (instead of strings) -> duration as double (instead of string) You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/125
-- Commit Summary --
* acc: add new types * acc: change type of core fields to real types
-- File Changes --
M modules/acc/acc_api.h (2) M modules/acc/acc_cdr.c (54)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/125.patch https://github.com/kamailio/kamailio/pull/125.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125
@mikomarrache just fix, amend and push using force to your branch.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-92802782
@linuxmaniac I fixed the error in the branch. What do you mean by amend and push using force?
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-92809450
I meant If you wanted to fix the original commit without having to create another one
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-92817043
You can also push a new patch to fix the issue in your branch and should appear in this pull request. Then it can be merge, but also the schema has to be changed and version increased for acc_cdrs table, via lib/srdb1/schema/acc_cdrs.xml. To generate the new db/sql creation scripts, run 'make dbschema'.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-92954481
I changed lib/srdb1/schema/acc_cdrs.xml as you asked and also included the fix.
I'm just a very beginner with Github, should I check out the branch, run the command and then commit?
Can you please provide me the right commands to checkout and commit?
Thanks Mickael
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-92992564
Well, you did what I said by pushing to your branch, all the patches appeared in the pull request.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-93051044
Thanks! The pull request will be merged.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-93274095
Merged #125.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#event-281848640
And what about upgrades from 4.2 to 4.3?? Is there any way to migrate the old values? What is the upgrade procedure here?
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-95932269
Maybe mysql can do conversion when running column change command:
``` ALTER TABLE acc_cdrs CHANGE COLUMN start_time ... ```
If not, we have to advise to backup the data, drop and recreate the table.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/125#issuecomment-95935483
-
Daniel-Constantin Mierla -
mikomarrache
-
Victor Seva