[kamailio/kamailio] pkg/kamailio/obs: Fixed warning about not existen kamailio group (#1756)
#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Kamailio is installed to systemd as member of "daemon" group. Fixed not correct group usage in spec file. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1756
-- Commit Summary --
* pkg/kamailio/obs: Fixed warning about not existen kamailio group
-- File Changes --
M pkg/kamailio/obs/kamailio.spec (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1756.patch https://github.com/kamailio/kamailio/pull/1756.diff
Isn't the group `kamailio` created with the install scripts from rpm? I think on debian, the group is created. It would be good to have same approach on both types of packaging, makes it easier for docs and being coherent no matter of operating system, as systemd is supposed to be same configs everywhere...
I looked into [kamailio.postinst](https://github.com/kamailio/kamailio/blob/master/pkg/kamailio/deb/debian/kam...) and can find add user command but cannot see group addition command. @linuxmaniac could you point me to group addition on debian packaging script.
Looks as here options `--system --group` is create group `kamailio`
From the manpage of adduser: If adduser is called with the --group option and without the --system option, or addgroup is called respectively, a user group will be added.
@sergey-safarov pushed 1 commit.
5f4d926b2ce62249af926719a74b060e703daebb Added group kamailio
PR is updated, but not tested locally. If now of, then i will test locally and squash commits.
The diff of the PR looks ok, so can be squashed and committed from my point of view.
PR is squashed and locally tested. Now ready to merge.
@sergey-safarov - you can merge and backport if needed.
Merged #1756 into master.
-
Daniel-Constantin Mierla -
sergey-safarov
-
Victor Seva