Differentiate the cases where AAR is not sent because of an error and the cases where AAR is not sent because it is logically wrong to sent them at that point of the transaction. In this way, in the routing script it is possible to distinguish between an error and (for example) send back an error to the UE and when AAR is not generated because (for example) the answer does not contain an SDP or you are not in a SIP reply. In this case, you should not send back an error but go ahead with your transaction. I noticed that CSCF_RETURN_FALSE (-1) is never used in the function, so it can be suitable to be returned in the cases just explained You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/314
-- Commit Summary --
* Return CSCF_RETURN_FALSE if AAR is not generated
-- File Changes --
M modules/ims_qos/mod.c (21)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/314.patch https://github.com/kamailio/kamailio/pull/314.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/314
Hopefully @jaybeepee or @ngvoice should be able to review this patch, being related to ims modules.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/314#issuecomment-138310080
Hi
This looks completely fine to me.
Regards
On 7 September 2015 at 16:19, Daniel-Constantin Mierla < notifications@github.com> wrote:
Hopefully @jaybeepee https://github.com/jaybeepee or @ngvoice https://github.com/ngvoice should be able to review this patch, being related to ims modules.
— Reply to this email directly or view it on GitHub https://github.com/kamailio/kamailio/pull/314#issuecomment-138310080.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/314#issuecomment-138317891
@richardgood - you can just merge it if is ok.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/314#issuecomment-138318109
Hi
Ok perfect will do.
Regards
*Richard Good* *Senior Manager: Applications & Services* *Smile Communications Pty (Ltd)* *Mobile:* +27 (0) 72 389 8365 * Skype:* richard.a.good richard.good@smilecoms.com name.surname@smilecoms.com www.smilecoms.com
On 7 September 2015 at 16:55, Daniel-Constantin Mierla < notifications@github.com> wrote:
@richardgood https://github.com/richardgood - you can just merge it if is ok.
— Reply to this email directly or view it on GitHub https://github.com/kamailio/kamailio/pull/314#issuecomment-138318109.
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Merged #314.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/314#event-402875243
Thanks everyone
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/314#issuecomment-138329211
-
Daniel-Constantin Mierla -
Federico Favaro
-
Richard Good -
richardgood