<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Please see conversation on ML for reference: https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1716
-- Commit Summary --
* Wait for network to be up before starting kamailio.service * Restart service if it fails with unclean exit code instead of only unclean signal
-- File Changes --
M pkg/kamailio/deb/bionic/kamailio.service (5) M pkg/kamailio/deb/buster/kamailio.service (5) M pkg/kamailio/deb/debian/kamailio.service (5) M pkg/kamailio/deb/jessie/kamailio.service (5) M pkg/kamailio/deb/sid/kamailio.service (5) M pkg/kamailio/deb/stretch/kamailio.service (5) M pkg/kamailio/deb/xenial/kamailio.service (5) M pkg/kamailio/oracle/el7/kamailio.service (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1716.patch https://github.com/kamailio/kamailio/pull/1716.diff
can you please follow the [commit guidelines](https://www.kamailio.org/wiki/devel/git-commit-guidelines) using `pkg/kamailio/deb` as the prefix?
I have now force-pushed the changes and remove the ol/el7 service file from the changes. Please let me know if that one should be fixed as well in a new PR.
@kevin-olbrich push those changes with the proper prefix `pkg/kamailio/oracle` here too, please
@kevin-olbrich pushed 1 commit.
8306adb pkg/kamailio/oracle: wait for network to be up
@kevin-olbrich push those changes with the proper prefix `pkg/kamailio/oracle` here too, please
Done
Merged #1716 into master.
Thanks!