When rtpengine answers with error-reason 'Ran out of ports' adopt the same behavor that when node answers 'Parallel session limit reached'
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x ] Commit message has the format required by CONTRIBUTING guide - [x ] Commits are split per component (core, individual modules, libs, utils, ...) - [ x] Each component has a single commit (if not, squash them into one commit) - [ x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Backport of the 'sessions limit' behavor for the 'Ran out of ports' error-reason.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2621
-- Commit Summary --
* rtpengine : add node fallback if node out of port
-- File Changes --
M src/modules/rtpengine/rtpengine.c (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2621.patch https://github.com/kamailio/kamailio/pull/2621.diff
@rfuchs - any opinion on this PR?
@rfuchs - any opinion on this PR?
Personally I wouldn't want to rely on a textual error message to control behaviour, but it's already been done before. So fine with me.
I haven't looked at the source code or the protocol, is there a response/error code that can be used instead of the text?
I haven't looked at the source code or the protocol, is there a response/error code that can be used instead of the text?
Well, it would have to be added :) We don't currently return error codes, but ideally something like that should be used instead of the text. But as we don't have that right now, can go with the error string for now.
OK, thanks! Going to merge it.
Merged #2621 into master.