THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#296 - tm:branch-failure event_route is not executed on all branch failures User who did this - Daniel-Constantin Mierla (miconda)
---------- With the last commit, tm will consider the branches that failed to be sent for failure routing blocks. At this moment such branch will fail after fr_timer (improvements to be added in the future), reply status code is 408.
However, branch failure route does not seem to be executed for the branches that don't get the negative reply from the network (e.g., case of local timeout, even for UDP), no branch failure route execution). Didn't have time to analyze properly, i'll have to see where Hugh added its execution.
For the moment, the failure_route[] blocks seems to be executed ok.
Note that t_relay() will return true in such case.
To enable this feature, you have to set module parameter failure_exec_mode to 1. ----------
More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=296#comment8...
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
daniel wrote:
For the moment, the failure_route[] blocks seems to be executed ok.
daniel,
i tested by setting normal failure route and branch failure route for a dead tcp destination. i have xlog info statement in the beginning of both and neither was executed:
May 19 21:56:37 siika /usr/sbin/sip-proxy[27361]: INFO: activating contact_failure failure route May 19 21:56:37 siika /usr/sbin/sip-proxy[27361]: INFO: activating contact branch_failure route May 19 21:56:37 siika /usr/sbin/sip-proxy[27361]: INFO: Routing INVITE sip:jh@192.98.102.10:5044;transport=tcp to contact via sip:192.98.102.10:42736;transport=TCP May 19 21:56:37 siika /usr/sbin/sip-proxy[27361]: ERROR: tm [../../forward.h:216]: msg_send(): msg_send: ERROR: tcp_send failed May 19 21:56:37 siika /usr/sbin/sip-proxy[27361]: ERROR: tm [t_fwd.c:1592]: t_send_branch(): ERROR: t_send_branch: sending request on branch 0 failed May 19 21:56:37 siika /usr/sbin/sip-proxy[27361]: ERROR: tm [t_fwd.c:1595]: t_send_branch(): putting branch 0 on hold
To enable this feature, you have to set module parameter failure_exec_mode to 1.
i did that.
next i tested to dead udp destination, and both branch and normal failure routes were executed after fr_timer fired:
May 19 22:04:34 siika /usr/sbin/sip-proxy[27577]: INFO: activating contact_failure failure route May 19 22:04:34 siika /usr/sbin/sip-proxy[27577]: INFO: activating contact branch_failure route May 19 22:04:34 siika /usr/sbin/sip-proxy[27577]: INFO: Routing INVITE sip:jh@192.98.102.10:5044;transport=udp to contact May 19 22:04:39 siika /usr/sbin/sip-proxy[27549]: INFO: event_route[tm:branch-failure:contact] May 19 22:04:39 siika /usr/sbin/sip-proxy[27549]: INFO: failure_route[contact]
-- juha