<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4276
-- Commit Summary --
* add remove all header function
-- File Changes --
M src/modules/pv_headers/pv_headers.c (9) M src/modules/pv_headers/pvh_func.c (19) M src/modules/pv_headers/pvh_func.h (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4276.patch https://github.com/kamailio/kamailio/pull/4276.diff
miconda left a comment (kamailio/kamailio#4276)
Shouldn't the function be better named `pvh_remove_all_headers` instead of `pvh_remove_all_header`?
@linuxmaniac: any other comments on this PR?
@fprdkhti pushed 1 commit.
62d7f8cfb080a20dec90049a3c426c6433d2cace pv_headers: Change name of function to pvh_remove_all_header
@fprdkhti pushed 1 commit.
41759bcea9aa328e3be7e763ba34c3337e31d144 pv_headers: Modify format with clang
fprdkhti left a comment (kamailio/kamailio#4276)
Shouldn't the function be better named `pvh_remove_all_headers` instead of `pvh_remove_all_header`?
@linuxmaniac: any other comments on this PR?
Yes. I fixed it. Thanks.
@linuxmaniac commented on this pull request.
@@ -128,6 +128,18 @@
pvh_collect_headers()</link> or with <quote>auto_msg</quote> parameter enabled. </para> </section> + <section id="pv_headers.f.pvh_remove_all_headers"> + <title> + <function moreinfo="none">pvh_remove_all_headers()</function> + </title> + <para> + Removes all headers from the XAVP.
Uhm... this it's not clear to me. It seems this will only remove the headers that are in the message, not the headers that could be added via ``$x_hdr``, for instance.
If that's what you want... please explain it here. Because I would expect all the headers to be removed not only the ones in the message.
@linuxmaniac commented on this pull request.
@@ -128,6 +128,18 @@
pvh_collect_headers()</link> or with <quote>auto_msg</quote> parameter enabled. </para> </section> + <section id="pv_headers.f.pvh_remove_all_headers"> + <title> + <function moreinfo="none">pvh_remove_all_headers()</function> + </title> + <para> + Removes all headers from the XAVP.
please rebase before sending the next version
@fprdkhti pushed 1 commit.
8910968974ade62195b79185bfc229bba06ac26f pv_headers: Add remove all header function
-
Daniel-Constantin Mierla -
Fateme Pardakhti
-
Victor Seva