9 Mar
2017
9 Mar
'17
11:47 a.m.
Module: kamailio
Branch: master
Commit: 2812b693b0ef97e3d720ff0b8a2982eeae566d71
URL: https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e…
Author: Stefan Mititelu <stefan.mititelu(a)onem.com>
Committer: Stefan Mititelu <stefan.mititelu(a)onem.com>
Date: 2017-03-09T10:47:00+02:00
rabbitmq: cleanup obsolete connection parameters
REVERT ME if you really need the old module parameters and are not able to update to
'url'.
---
Modified: src/modules/rabbitmq/README
Modified: src/modules/rabbitmq/doc/rabbitmq_admin.xml
Modified: src/modules/rabbitmq/rabbitmq.c
---
Diff:
https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e…
Patch:
https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e…
9 Mar
9 Mar
2:58 p.m.
New subject: git:master:2812b693: rabbitmq: cleanup obsolete connection parameters
Hello,
it is no longer needed to generate the README and push it on the git
repository after changing the docbook xml files. There is a tool running
now on server refreshing the READMEs and updating them on git repository
-- it ensures also a coherent format in the readmes for chapters and
sections.
Another thing is that the commit message should not contain such remarks
like "REVERT ME ...", it should strictly describe the changes. You can
write to sr-dev or let a comment on the git commit via github interface
(that will be also forwarded to sr-dev) saying that.
None of the above is something critical that has to be reworked for this
case (so no revert), I wrote to clarify and have in mind for the future.
Cheers,
Daniel
On 09/03/2017 09:47, Stefan Mititelu wrote:
Module: kamailio
Branch: master
Commit: 2812b693b0ef97e3d720ff0b8a2982eeae566d71
URL:
https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e…
Author: Stefan Mititelu <stefan.mititelu(a)onem.com>
Committer: Stefan Mititelu <stefan.mititelu(a)onem.com>
Date: 2017-03-09T10:47:00+02:00
rabbitmq: cleanup obsolete connection parameters
REVERT ME if you really need the old module parameters and are not able to update to
'url'.
---
Modified: src/modules/rabbitmq/README
Modified: src/modules/rabbitmq/doc/rabbitmq_admin.xml
Modified: src/modules/rabbitmq/rabbitmq.c
---
Diff:
https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e…
Patch:
https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e…
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
--
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Mar 6-8 (Europe) and Mar 20-22 (USA) - www.asipto.com
Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com
5:27 p.m.
New subject: git:master:2812b693: rabbitmq: cleanup obsolete connection parameters
Thank you Daniel for the advices.
Stefan
<http://www.onem.com/> *STEFAN MITITELU*
VoIP Engineer
+447479572798
stefan.mititelu(a)onem.com <myhoa.tien(a)onem.com>
www.onem.com
Stirbei Voda, 114-116
Bucharest, 10119
Romania
On Thu, Mar 9, 2017 at 1:58 PM, Daniel-Constantin Mierla <miconda(a)gmail.com>
wrote:
Hello,
it is no longer needed to generate the README and push it on the git
repository after changing the docbook xml files. There is a tool running
now on server refreshing the READMEs and updating them on git repository
-- it ensures also a coherent format in the readmes for chapters and
sections.
Another thing is that the commit message should not contain such remarks
like "REVERT ME ...", it should strictly describe the changes. You can
write to sr-dev or let a comment on the git commit via github interface
(that will be also forwarded to sr-dev) saying that.
None of the above is something critical that has to be reworked for this
case (so no revert), I wrote to clarify and have in mind for the future.
Cheers,
Daniel
On 09/03/2017 09:47, Stefan Mititelu wrote:
Module: kamailio
Branch: master
Commit: 2812b693b0ef97e3d720ff0b8a2982eeae566d71
URL: https://github.com/kamailio/kamailio/commit/
2812b693b0ef97e3d720ff0b8a2982eeae566d71
Author: Stefan Mititelu <stefan.mititelu(a)onem.com>
Committer: Stefan Mititelu <stefan.mititelu(a)onem.com>
Date: 2017-03-09T10:47:00+02:00
rabbitmq: cleanup obsolete connection parameters
REVERT ME if you really need the old module parameters and are not able
to update
to 'url'.
---
Modified: src/modules/rabbitmq/README
Modified: src/modules/rabbitmq/doc/rabbitmq_admin.xml
Modified: src/modules/rabbitmq/rabbitmq.c
---
Diff: https://github.com/kamailio/kamailio/commit/
2812b693b0ef97e3d720ff0b8a2982eeae566d71.diff
2812b693b0ef97e3d720ff0b8a2982eeae566d71.patch
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
--
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Mar 6-8 (Europe) and Mar 20-22 (USA) -
www.asipto.com
Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com
2819
days inactive
2819
days old
2 comments
2 participants
participants (2)
-
Daniel-Constantin Mierla -
Stefan Mititelu