THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Pawel Sternal (Sternik)
Attached to Project - sip-router Summary - Entity URI in NOTIFY XML body Task Type - Improvement Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - Hi. We had a small problem with polycom phones to realize blf functionality. On yealink, cisco, aastra etc works like a charm. We discover that in xml body of NOTIFY, entity uri doesn't contain a "sip:" value. In RFC 4235 however in xml body "sip:" is on every example. I've modify notify_body.c in presence_dialoginfo module to enable BLF functionality for polycom phone by adding "sip:" to entity pres and it works. I wonder it's ok?
I've attach sip trace before the change and diff of notify_body.
One or more files have been attached.
More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=324
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
sip-router writes:
Details - Hi. We had a small problem with polycom phones to realize blf functionality. On yealink, cisco, aastra etc works like a charm. We discover that in xml body of NOTIFY, entity uri doesn't contain a "sip:" value. In RFC 4235 however in xml body "sip:" is on every example. I've modify notify_body.c in presence_dialoginfo module to enable BLF functionality for polycom phone by adding "sip:" to entity pres and it works. I wonder it's ok?
i have noticed uri scheme missing from entity uri also in other presence documents not related to blf. in my opinion, the clients should be fixed rather that start patching them in sip proxy or xcap server.
-- juha
On 7/12/13 12:28 PM, Juha Heinanen wrote:
sip-router writes:
Details - Hi. We had a small problem with polycom phones to realize blf functionality. On yealink, cisco, aastra etc works like a charm. We discover that in xml body of NOTIFY, entity uri doesn't contain a "sip:" value. In RFC 4235 however in xml body "sip:" is on every example. I've modify notify_body.c in presence_dialoginfo module to enable BLF functionality for polycom phone by adding "sip:" to entity pres and it works. I wonder it's ok?
i have noticed uri scheme missing from entity uri also in other presence documents not related to blf. in my opinion, the clients should be fixed rather that start patching them in sip proxy or xcap server.
the question is which format is the correct one (entity value with uri shcema (sip:) or without)? Or maybe both formats are ok?!?
Cheers, Daniel
Daniel-Constantin Mierla writes:
the question is which format is the correct one (entity value with uri shcema (sip:) or without)? Or maybe both formats are ok?!?
as it was mentioned by the author, all examples in standards include uri scheme and in the document syntax specify uri. uri always contains uri scheme, otherwise it is not uri.
-- juha
On 7/12/13 2:20 PM, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
the question is which format is the correct one (entity value with uri shcema (sip:) or without)? Or maybe both formats are ok?!?
as it was mentioned by the author, all examples in standards include uri scheme and in the document syntax specify uri. uri always contains uri scheme, otherwise it is not uri.
It was not clear from your previous statement that your experience with other cases when there was no schema was the right or wrong way. Because the patch adds schema to entity in an xml doc constructed by presence_dialoginfo module. Therefore seems to be a bug in the module if sip: is missing, which is fixed by that patch.
Cheers, Daniel
Daniel-Constantin Mierla writes:
It was not clear from your previous statement that your experience with other cases when there was no schema was the right or wrong way. Because the patch adds schema to entity in an xml doc constructed by presence_dialoginfo module. Therefore seems to be a bug in the module if
e> sip: is missing, which is fixed by that patch.
ok, i thought that the erroneous document was generated by a sip or xcap ua.
-- juha
-
Daniel-Constantin Mierla -
Juha Heinanen -
sip-router