- websocket connections are created with a BUF_SIZE (64K) buffer used for concatenating frames - continuation frames (fragments) are supported for the SIP sub-protocol You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/344
-- Commit Summary --
* websocket: Add support for SIP message fragmentation
-- File Changes --
M modules/websocket/ws_conn.c (5) M modules/websocket/ws_conn.h (2) M modules/websocket/ws_frame.c (59)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/344.patch https://github.com/kamailio/kamailio/pull/344.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/344
You can merge it and you can directly push the commits to websocket module, without doing push requests -- guess @pdunkley is ok with that.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/344#issuecomment-142926437
Merged #344.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/344#event-418108507
Thanks! For some features, I like to check with other devs that I'm not in conflict with the existing style or causing any unintended consequences!
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/344#issuecomment-142931733
OK, that's fine, just wanted to say that if you feel it should be pushed directly, then it is ok to do it.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/344#issuecomment-142932165
-
Daniel-Constantin Mierla -
Hugh Waite