The function is only called from the xs file, and C11’s inline semantics mean that gcc-5 and later miscompile this file when no optimization is specified.
Signed-off-by: James Cloos cloos@jhcloos.com You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1020
-- Commit Summary --
* Make app_perl’s sv2int_str() static
-- File Changes --
M src/modules/app_perl/kamailioxs.xs (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1020.patch https://github.com/kamailio/kamailio/pull/1020.diff
Can you update the commit message to follow the recommendations from contributions guide?
* https://www.kamailio.org/wiki/devel/github-contributions#commit_message_form...
The commit messages are used to generate the changelog and it is good to have a coherence there.
Closed #1020.
Re-submitting.
Reopened #1020.
Github didn’t bother to email me your comment; I just happened on it today.
The current tip of https://github.com/jhcloos/kamailio.git master has the updated commit. I can’t tell whether this web ui is doing the right thing....
Merged #1020.
-
Daniel-Constantin Mierla -
James Cloos