#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description `websocket` and `phonenum` are not build on FreeBSD environment. The proposed patch fixes it and makes modules are consistent with the rest of modules. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3000
-- Commit Summary --
* phonenum: Makefile - support for FreeBSD build * websocket: Makefile - support for FreeBSD build
-- File Changes --
M src/modules/phonenum/Makefile (9) M src/modules/websocket/Makefile (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3000.patch https://github.com/kamailio/kamailio/pull/3000.diff
@drTr0jan pushed 1 commit.
951f82db6d17d5fb8296de9f675dc931c0774288 rtp_media_server: Makefile - support for FreeBSD build
@miconda commented on this pull request.
@@ -5,13 +5,8 @@ include ../../Makefile.defs
auto_gen= NAME=phonenum.so
-CXX=g++ -LD=g++
Probably instead of removing, it's better to set CXX and LD if not set yet.
@miconda commented on this pull request.
@@ -5,13 +5,8 @@ include ../../Makefile.defs
auto_gen= NAME=phonenum.so
-CXX=g++ -LD=g++ -LIB_DIR = /opt/local/lib - -LIBS= -L${LIB_DIR} cphonenumber.o -lphonenumber -lgeocoding -
The cphonenumber.o is needed for linking, not sure it would work without, expecting missing symbols. Have you started kamailio with this module, or just compiled it?
@drTr0jan pushed 3 commits.
1eab0d2559e8625f0af1709df401e8ede3ab1800 phonenum: Makefile - support for FreeBSD build e6c6a6e4435d37ffb414fc649b710365ab0b52ad websocket: Makefile - support for FreeBSD build ca4a0b586a99d09d4042d7df2ff95cce12808dbb rtp_media_server: Makefile - support for FreeBSD build
@drTr0jan commented on this pull request.
@@ -5,13 +5,8 @@ include ../../Makefile.defs
auto_gen= NAME=phonenum.so
-CXX=g++ -LD=g++ -LIB_DIR = /opt/local/lib - -LIBS= -L${LIB_DIR} cphonenumber.o -lphonenumber -lgeocoding -
Yep, you are right.
Thanks!
Merged #3000 into master.
-
Boris Korzun -
Daniel-Constantin Mierla