12 Jul
2017
12 Jul
'17
5:12 p.m.
cockroachdb does not have support for 32-bit integers
this commit adds basic support into the version table by allowing 64-bit integers from
cockroachdb
cockroachdb support can be implemented on a per module basis from here on
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1186
-- Commit Summary --
* core: allow 64-bit integer when checking version number
-- File Changes --
M src/lib/srdb1/db.c (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1186.patch
https://github.com/kamailio/kamailio/pull/1186.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1186
12 Jul
12 Jul
6:28 p.m.
Did you want to check for DB1_BIGINT instead of DB1_DOUBLE?
What's the use case for this patch? Table version is cleated with int column.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1186#issuecomment-314856653
6:35 p.m.
this is the table schema i loaded into cockroachdb
```
CREATE TABLE version (
table_name text,
table_version INT
);
```
the result type detected by kamailio for the `table_version` column matches DB1_DOUBLE.
i discovered this by outputting VAL_TYPE(ver) to the log.
if DB1_BIGINT will match, im ok with that change too.
The use case is to add support to cockroachdb (which supports postgresql-client lib)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1186#issuecomment-314858361
6:47 p.m.
The description of the pull request/patch is wrong then, because DB1_DOUBLE is a floating
point, not an integer.
Eventually you can add support for both DB1_BIGINT and DB1_DOUBLE. However, few remarks:
* use if-else, to be more optimal and avoid unnecessary evaluations of conditions, with
check for DB1_INT being the first
* for DB1_BIGINT and DB1_DOUBLE do cast to (int), otherwise there will be warnings on
strict compilers
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1186#issuecomment-314861716
13 Jul
13 Jul
6:57 a.m.
New subject: [kamailio/kamailio] core: add support for float and bigint when checking table version number (#1186)
The DB1_DOUBLE type might have been the result of the bug fixed with
d12f96af28e170c3197a47af5840e5e30639adf6 .
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1186#issuecomment-314989528
7:08 a.m.
New subject: [kamailio/kamailio] core: add support for float and bigint when checking table version number (#1186)
Closed #1186.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1186#event-1162020308
7:08 a.m.
New subject: [kamailio/kamailio] core: add support for float and bigint when checking table version number (#1186)
The patch related to value type was applied manually, the commit message was not
reflecting the component and the description was too vague. The one with fixing
whitespaces was not applied. You can commit it if you want, but prefix the commit message
with 'lib/srdb1: ...'.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1186#issuecomment-314991746
2560
days inactive
2561
days old
6 comments
2 participants
participants (2)
-
Daniel-Constantin Mierla -
Emmanuel Schmidbauer