On May 25, 2015, at 11:55 AM, Seudin Kasumovic
<seudin(a)bicomsystems.com> wrote:
Hi Daniel,
On May 25, 2015, at 9:43 AM, Daniel-Constantin
Mierla <miconda(a)gmail.com> wrote:
Hello,
I noticed that erlang module is exporting couple of config variable
classes (pseudo-variables) with various names. I would suggest to prefix
them with 'erl' or something similar to know they are related and
specific to erlang module. Many modules do so already (e.g., tm uses
$T...). You used some generic names that could be confusing at some
point with other components (e.g., 'tuple' is also used a lot in
presence, 'pid' is something common any process and kamailio has also
some variable related to it).
Prefix ‘erl_’ is used for functions in Erlang module, so prefixing PVs too will be
confusing between functions and PVs.
I will consider other prefixes ‘$e_’ or ’$E_’ for vars.
Another note: documenting PVs in README is ok,
but then need to be also
documented in the wiki cookbook:
-
http://www.kamailio.org/wiki/cookbooks/devel/pseudovariables
How to patch cookbook?
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda -
http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany -
http://www.kamailioworld.com
Regards,
Seudin