[kamailio/kamailio] presence: add parameter `fix_startup` to disable 1dceaa24ded727aba5870f28fb63e26ed98464f3 (#854)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/854
-- Commit Summary --
* presence: cleanup whitespace in notify.c * presence: add parameter fix_startup
-- File Changes --
M modules/presence/doc/presence_admin.xml (22) M modules/presence/notify.c (287) M modules/presence/presence.c (5) M modules/presence/presence.h (1) M modules/presence/presentity.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/854.patch https://github.com/kamailio/kamailio/pull/854.diff
I would propose to rename the new parameter, because the chosen on is misleading, given that it doesn't fix a clear issue (like a leak in a specific version of an external library), but it selects in doing or not some sort of operation at startup. I would go for **startup_mode**, if there is no other better suggestion. In the future it can be used for controlling other kinds of operations at startup for the module.
Thanks
Merged #854.
I did a cleanup of extra unnecessary global variable used to implement the startup mode parameter. No testing, report if you find something working wrong.
-
Daniel-Constantin Mierla -
Emmanuel Schmidbauer