THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#386 - acc: allow pvar as first parameter for functions User who did this - Daniel-Constantin Mierla (miconda) ---------- Few comments: - the comparison to detect if it is a variable should be done against PV_MARKER instead of '$', to be easy to spot/maintain - i think the code can be kept optimized when a static string is provided, so in this case it is parsed only at startup. If it is a variable, then acc_get_param_value() will do the parsing with most of the code inside the IF. If not variable, the parsing is still done in the fixup. As an enhancement, I would allow a dynamic string (e.g., "$var(code) message $var(msg)") as parameter, not only a single variable. That means the fixup should search for PV_MARKER inside the parameter and if found then use pv_parse_format() in fixup and pv_printf_s() in acc_get_param_value(). ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=386#comment1… You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.