<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> We have found a random crash in the CTL module handler and we are using kamailio 5.4.7. Based on the core log analysis, we have identified that, due to some of the RPC events this crash happens.
This crash happen when "rpc_mod_is_printed_one" funtion recevies the parameter ( mem_counter *stats ) as NULL. To avoid the crash, we have added the below code. if ( stats == NULL || current == NULL ) { LM_ERR("rpc_mod_is_printed_one -> funtion parameter contains null value \n"); return 1; }
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3250
-- Commit Summary --
* Update mod_stats.c Random crash in CTL handler
-- File Changes --
M src/modules/kex/mod_stats.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3250.patch https://github.com/kamailio/kamailio/pull/3250.diff
Thanks for the pull request. Could you remove the function name from the log output? This is added automatically from the logging framework. You can just update this PR with a force-push, i think.
@henningw - As per your suggestion, we have done the correction. please review it
Its not updated yet - but don't worry, I will apply it manually as the commit log message is also not in the correct format.
@henningw - Thanks
thanks, merged manually
Closed #3250.
Hi @henningw @miconda ,
Thanks for committed the safety check code in 5.6 release. Is there any possibility to commit this in 5.4 release too?
Thanks, Bensly
I've also cherry-picked it to 5.5.x branch. Regarding 5.4.x branch, this is end of life and will not get any more updates. Consider to upgrade to either 5.5.x or 5.6.x branch.