Hi,
in presence module subscribe.c send_fast_notify is not always honored. by changing this line i got it working. does this make sense ?
thanks
diff --git a/modules/presence/subscribe.c b/modules/presence/subscribe.c index 3074ca9..f5dd6aa 100644 --- a/modules/presence/subscribe.c +++ b/modules/presence/subscribe.c @@ -682,7 +682,7 @@ } else { - if(notify(subs, NULL, NULL, 0)< 0) + if(send_fast_notify && (notify(subs, NULL, NULL, 0 )< 0)) { LM_ERR("Could not send notify\n"); goto error;
Hello,
thanks for your patches, I will review and commit.
Cheers, Daniel
On 03/09/14 12:32, Luis Azedo wrote:
Hi,
in presence module subscribe.c send_fast_notify is not always honored. by changing this line i got it working. does this make sense ?
thanks
diff --git a/modules/presence/subscribe.c b/modules/presence/subscribe.c index 3074ca9..f5dd6aa 100644 --- a/modules/presence/subscribe.c +++ b/modules/presence/subscribe.c @@ -682,7 +682,7 @@ } else { -if(notify(subs, NULL, NULL, 0)< 0) +if(send_fast_notify && (notify(subs, NULL, NULL, 0 )< 0)) { LM_ERR("Could not send notify\n"); goto error;
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hello,
thanks, the patch is now on master branch and will be backported.
Cheers, Daniel
On 03/09/14 12:32, Luis Azedo wrote:
Hi,
in presence module subscribe.c send_fast_notify is not always honored. by changing this line i got it working. does this make sense ?
thanks
diff --git a/modules/presence/subscribe.c b/modules/presence/subscribe.c index 3074ca9..f5dd6aa 100644 --- a/modules/presence/subscribe.c +++ b/modules/presence/subscribe.c @@ -682,7 +682,7 @@ } else { -if(notify(subs, NULL, NULL, 0)< 0) +if(send_fast_notify && (notify(subs, NULL, NULL, 0 )< 0)) { LM_ERR("Could not send notify\n"); goto error;
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-
Daniel-Constantin Mierla -
Luis Azedo