[kamailio/kamailio] wip: pua_reginfo: add helper to disable publishing for current message (PR #4253)
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4252
#### Description This PR adds a new helper `reginfo_disable_publish` to `pua_reginfo` module which disabled the publishing for the current message, which is useful to control when to actually send it or not (eg in DMQ replication scenarios).
The helper is "negative" (it *disables* not enables) on purpose in order to mantain backward compatibility to current behaviour.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4253
-- Commit Summary --
* pua_reginfo: add helper to disable publishing for current message
-- File Changes --
M src/modules/pua_reginfo/pua_reginfo.c (4) M src/modules/pua_reginfo/pua_reginfo.h (4) M src/modules/pua_reginfo/usrloc_cb.c (21)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4253.patch https://github.com/kamailio/kamailio/pull/4253.diff
xadhoom left a comment (kamailio/kamailio#4253)
If the PR is ok I'll also add docs before marking as ready
xadhoom left a comment (kamailio/kamailio#4253)
Also, the functions are split to be ready to be added to kemi, only later I found out that pua_reginfo is not kemi aware yet. I can simplify the two functions in one, leave as is or add all kemi stuff, too
henningw left a comment (kamailio/kamailio#4253)
Also, the functions are split to be ready to be added to kemi, only later I found out that pua_reginfo is not kemi aware yet. I can simplify the two functions in one, leave as is or add all kemi stuff, too
Not sure if I fully understood your question. If you also want to add KEMI support for pua_reginfo module, its better to do it as a dedicated PR and commit, as this makes reviewing and merging easier. The KEMI could be also backported, which is not possible for new functionality.
xadhoom left a comment (kamailio/kamailio#4253)
Not sure if I fully understood your question. If you also want to add KEMI support for pua_reginfo module, its better to do it as a dedicated PR and commit, as this makes reviewing and merging easier. The KEMI could be also backported, which is not possible for new functionality.
No I don't want to add kemi here. I was just commenting of my own PR which has 2 functions, one of which is "ready" for kemi. I can just leave as is, or collapse into one function (because without kemi is not really needed), that's all.
xadhoom left a comment (kamailio/kamailio#4253)
Updated with docs.
@xadhoom pushed 1 commit.
fefdfd4c3801d9a436319f4d94e73673e5b1ccb4 pua_reginfo: add helper to disable publishing for current message
-
Henning Westerholt -
Matteo