#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally <!-- - [ ] Related to issue # -->
#### Description Still WIP
* use [PKG|SHM]_MEM_ERROR * use memset and avoid initialization per field * init variables * add cnxcc to lgtm build
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2343
-- Commit Summary --
* cnxcc: minor changes
-- File Changes --
M .lgtm.yml (3) M src/modules/cnxcc/cnxcc_mod.c (61) M src/modules/cnxcc/cnxcc_redis.c (29) M src/modules/cnxcc/cnxcc_rpc.c (30) M src/modules/cnxcc/cnxcc_sip_msg_faker.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2343.patch https://github.com/kamailio/kamailio/pull/2343.diff
This pull request **introduces 5 alerts** when merging aa2f42d2a1d3a8a87c925deef570dfa38cc1915f into 2d58abdc01372898f61d2c09190fdce2681eb738 - [view on LGTM.com](https://lgtm.com/projects/g/kamailio/kamailio/rev/pr-1901d8914cdf455316a6769...)
**new alerts:**
* 3 for Local variable hides global variable * 1 for Use of potentially dangerous function * 1 for Ambiguously signed bit-field member
@linuxmaniac pushed 1 commit.
a98833eb9f3456701712af78969f69ff30350a7a cnxcc: minor changes
@linuxmaniac pushed 1 commit.
396c7322a9f30e494637df0a11bacf2dbbfe5c32 cnxcc: minor changes
Merged #2343 into master.