Module: sip-router Branch: master Commit: e7e131d5b5abec9440f0963375abd1940d65e3f4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e7e131d5...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: Wed Oct 24 00:05:13 2012 +0200
sercmd: builds and installs as kamcmd when FLAVOUR=kamailio
- avoid packaging conflicts with ser (both packages attempt to install same file)
---
utils/sercmd/Makefile | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/utils/sercmd/Makefile b/utils/sercmd/Makefile index 2cb406a..dacd064 100644 --- a/utils/sercmd/Makefile +++ b/utils/sercmd/Makefile @@ -4,8 +4,13 @@ include $(COREPATH)/Makefile.defs include $(COREPATH)/Makefile.targets
auto_gen= -NAME=sercmd RELEASE=0.2 +UTIL_SRC_NAME=sercmd +ifeq ($(FLAVOUR),kamailio) + NAME=kamcmd +else + NAME=sercmd +endif
readline_locations= /usr/include/readline/readline.h \ $(LOCALBASE)/include/readline/readline.h
24 okt 2012 kl. 08:40 skrev Daniel-Constantin Mierla miconda@gmail.com:
sercmd: builds and installs as kamcmd when FLAVOUR=kamailio
Should we add a symlink at install for backwards compatibility?
/O
On 10/24/12 11:14 AM, Olle E. Johansson wrote:
24 okt 2012 kl. 08:40 skrev Daniel-Constantin Mierla miconda@gmail.com:
sercmd: builds and installs as kamcmd when FLAVOUR=kamailio
Should we add a symlink at install for backwards compatibility?
This exposes the same problem -- a conflict on sercmd file when installing kamailio and ser from packages.
Here is the link on debian reported issue some time ago:
http://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1041184.htm...
Cheers, Daniel
24 okt 2012 kl. 12:12 skrev Daniel-Constantin Mierla miconda@gmail.com:
On 10/24/12 11:14 AM, Olle E. Johansson wrote:
24 okt 2012 kl. 08:40 skrev Daniel-Constantin Mierla miconda@gmail.com:
sercmd: builds and installs as kamcmd when FLAVOUR=kamailio
Should we add a symlink at install for backwards compatibility?
This exposes the same problem -- a conflict on sercmd file when installing kamailio and ser from packages.
Thinking loud:
Hmm. So if SER is installed after kamailio, we have an issue with a symlink. If the SER install removes existing sercmd before installing anything we won't have an issue. If Kamailio install only installs symlink if sercmd does *NOT* exist we won't have an issue.
But we should *not* install symlink when installing packages, only from source.
Would that be possible to handle?
I think maintaining backwards compatibility is a good thing (TM).
/O
Here is the link on debian reported issue some time ago:
http://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1041184.htm...
Cheers, Daniel
-- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat Kamailio Advanced Training, Miami, USA, Nov 12-14, 2012 - http://asipto.com/u/katu
On 10/24/12 4:21 PM, Olle E. Johansson wrote:
24 okt 2012 kl. 12:12 skrev Daniel-Constantin Mierla miconda@gmail.com:
On 10/24/12 11:14 AM, Olle E. Johansson wrote:
24 okt 2012 kl. 08:40 skrev Daniel-Constantin Mierla miconda@gmail.com:
sercmd: builds and installs as kamcmd when FLAVOUR=kamailio
Should we add a symlink at install for backwards compatibility?
This exposes the same problem -- a conflict on sercmd file when installing kamailio and ser from packages.
Thinking loud:
Hmm. So if SER is installed after kamailio, we have an issue with a symlink. If the SER install removes existing sercmd before installing anything we won't have an issue. If Kamailio install only installs symlink if sercmd does *NOT* exist we won't have an issue.
But we should *not* install symlink when installing packages, only from source.
Would that be possible to handle?
I think maintaining backwards compatibility is a good thing (TM).
Building a packages involves calling 'make install', resulting in a conflict. Maybe a new target can be added, like 'make install-compat' that can add such symlink, used only from command line when wanted.
On the other hand, with this upcoming release we are going to get rid of 'openser' references (e.g., in database name, users, ...), so there will be a dedicated session to underline these changes, where we lose some backward compatible stuff (including in Perl scripting, perhaps snmpstats stuff, ...).
Cheers, Daniel
/O
Here is the link on debian reported issue some time ago:
http://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1041184.htm...
Cheers, Daniel
-- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat Kamailio Advanced Training, Miami, USA, Nov 12-14, 2012 - http://asipto.com/u/katu
-
Daniel-Constantin Mierla -
Olle E. Johansson