another possibility to make fixups scalable would be to specify the argument of the fixup function, something like
{"test", (cmd_function)test, generic_fixup, "pvar,str,spve", REQUEST_ROUTE | FAILURE_ROUTE},
then it would be easy to write this generic fixup function that would accept a list of known parameter types as the argument.
now that functions can have more than two args, the fixup system must be fixed in order to make writing of modules easier. i would be trivial for me to clean the enum module functions if the fixup system would be more user friendly.
-- juha
Hello,
On 4/8/10 10:06 AM, Juha Heinanen wrote:
another possibility to make fixups scalable would be to specify the argument of the fixup function, something like
{"test", (cmd_function)test, generic_fixup, "pvar,str,spve", REQUEST_ROUTE | FAILURE_ROUTE},
then it would be easy to write this generic fixup function that would accept a list of known parameter types as the argument.
now that functions can have more than two args, the fixup system must be fixed in order to make writing of modules easier. i would be trivial for me to clean the enum module functions if the fixup system would be more user friendly.
afaik Andrei is working with a new module interface, in branch andrei/rve_f_params, to allow using expressions in config for function parameters. It should work at the same time with existing module interfaces, so no massive changes will be required to existing code, just for the case when a devel needs it or wants to upgrade some modules.
Perhaps is time to brainstorm and find a proper fixup system as well.
Cheers, Daniel
-
Daniel-Constantin Mierla -
jh＠tutpro.com