<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3831
#### Description <!-- Describe your changes in detail -->
The `tm` currently does not trigger the `tm:local-request` event for CANCEL requests that are created by the tm.cancel RPC function. This pull request adds support for triggering the tm:local-request event for CANCEL requests.
According to [docs](https://www.kamailio.org/docs/modules/devel/modules/tm#tm.e.local-request) an event `tm:local-request` should be created for every request that is originates from kamailio and creates a transaction.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3962
-- Commit Summary --
* tm: Emit request event when cancel is called
-- File Changes --
M src/modules/tm/t_cancel.c (62)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3962.patch https://github.com/kamailio/kamailio/pull/3962.diff
A couple of issues/suggestions:
- I would not allocate msg, declaring it as a local sip_msg_t should enough - no matter if msg is pointer or sip_msg_t, free_sip_msg() has to be used to clean up allocated memory by parsing - I would not run the event route with a faked message, either the cancel is built/parsed fine and run the event route, or throw an error message - the condition to execute the event route should be useless, there are some returns before that should ensure that either there is a proper event_route block or a kemi callback event name.
@xkaraman pushed 1 commit.
a1332cf4feff836f7296b150de12d8cb36e78526 tm: Emit request event when cancel is called
@xkaraman pushed 1 commit.
1474e5f09549a60f673424c664370d8a7d32d808 tm: Emit request event when cancel is called
@miconda All suggestions should be resolved now!
@xkaraman pushed 1 commit.
12cf448e323e5243fe546b09699c4664d941469f tm: Emit request event when cancel is called
Do you have any feedback on this? Otherwise, it can probably be merged.
Merged #3962 into master.