<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Allows kamailio to connect to a sentinel to find out which redis instance to connect to. I modified the README in this commit but this is the generated file, I did not change it by hand.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1493
-- Commit Summary --
* ndb_redis: adds support for sentinel
-- File Changes --
M src/modules/ndb_redis/README (9) M src/modules/ndb_redis/doc/ndb_redis_admin.xml (7) M src/modules/ndb_redis/redis_client.c (75) M src/modules/ndb_redis/redis_client.h (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1493.patch https://github.com/kamailio/kamailio/pull/1493.diff
Thanks! One question before attempting to merge, does this require a specific version of redis server or redis client library?
After a quick look on redis website the sentinel is shipped with redis since 2.8 so I suppose this is the minimum required but if the sentinel options are not used the driver should work as before with any redis version.
Thanks for the additional details. I am merging it.
For the future -- the README should no longer be regenerated even when changing in xml file, the reason is that various systems format the text file differently and it can result in a large diff (hard to backport if it is the case, etc.). Here is ok, just to have in mind.
Merged #1493.